Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 254943002: Revert of Stop passing chrome.test.fail as ErrorCallback (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
Reviewers:
hirono, hashimoto
CC:
chromium-reviews, extensions-reviews_chromium.org, vandebo (ex-Chrome), Lei Zhang, yoshiki+watch_chromium.org, tommycli, rginda+watch_chromium.org, Greg Billock, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert of Stop passing chrome.test.fail as ErrorCallback (https://codereview.chromium.org/258523004/) Reason for revert: Suspected for making OpenAudioFiles/FileManagerBrowserTest.Test/{0,1} flaky/racy since http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/10706 Errors like: [26400:26400:0426/004939:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in undefined: Displayed data of 1st file is wrong. Actual: Beautiful Song.ogg Expected: Beautiful Song ... at chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/open_audio_files.js:90:21", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0) [26400:26400:0426/004939:INFO:CONSOLE(0)] "[FAIL] undefined: chrome.test.failure Original issue's description: > Stop passing chrome.test.fail as ErrorCallback > > chrome.test.fail cannot be used as ErrorCallback because it throws exception when the number of arguments doesn't match. > This wrong use of chrome.test.fail makes the error output useless when something goes wrong. > > BUG=None > TEST=browser_tests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266271 TBR=hirono@chromium.org,hashimoto@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266416

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of Stop passing chrome.test.fail as ErrorCallback
6 years, 7 months ago (2014-04-28 00:34:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/254943002/1
6 years, 7 months ago (2014-04-28 00:35:10 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 00:36:23 UTC) #3
Message was sent while issue was closed.
Change committed as 266416

Powered by Google App Engine
This is Rietveld 408576698