chrome/test/data/extensions/api_test/file_browser/file_browser_handler_lazy/background.js - Issue 254943002: Revert of Stop passing chrome.test.fail as ErrorCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/file_browser/file_browser_handler_lazy/background.js

Issue 254943002: Revert of Stop passing chrome.test.fail as ErrorCallback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/file_browser/file_browser_handler/background.js ('k') | chrome/test/data/extensions/api_test/file_browser/filesystem_operations_test/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/file_browser/file_browser_handler_lazy/background.js

diff --git a/chrome/test/data/extensions/api_test/file_browser/file_browser_handler_lazy/background.js b/chrome/test/data/extensions/api_test/file_browser/file_browser_handler_lazy/background.js

index 4024c015bb4bd398a0c818ca6e3eae3053a9a598..25c14808b6b7862b1982ec76796947e13023cc94 100644

--- a/chrome/test/data/extensions/api_test/file_browser/file_browser_handler_lazy/background.js

+++ b/chrome/test/data/extensions/api_test/file_browser/file_browser_handler_lazy/background.js

@@ -112,9 +112,10 @@

function getSiblingTest(entry) {

var error = 'Got file (\'' + entry.fullPath.concat('.foo') + '\') for which' +

'file access was not granted.';

- entry.filesystem.root.getFile(entry.fullPath.concat('.foo'), {},

- function (entry) { chrome.test.fail(error); },

- chrome.test.succeed);

+ entry.filesystem.root.getFile(

+ entry.fullPath.concat('.foo'), {},

+ chrome.test.fail.bind(null, error),

+ chrome.test.succeed);

}

/**