chrome/test/data/extensions/api_test/file_browser/app_file_handler/background.js - Issue 254943002: Revert of Stop passing chrome.test.fail as ErrorCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/file_browser/app_file_handler/background.js

Issue 254943002: Revert of Stop passing chrome.test.fail as ErrorCallback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/extensions/api_test/file_browser/app_file_handler/background.js

diff --git a/chrome/test/data/extensions/api_test/file_browser/app_file_handler/background.js b/chrome/test/data/extensions/api_test/file_browser/app_file_handler/background.js

index 6987499c8f15e05b28ef8ded3ba84daa1a929075..c0b1269c416e4284d87644fbecc7b1596e9b766c 100644

--- a/chrome/test/data/extensions/api_test/file_browser/app_file_handler/background.js

+++ b/chrome/test/data/extensions/api_test/file_browser/app_file_handler/background.js

@@ -34,9 +34,8 @@

chrome.test.fail('Error reading file contents.');

};

reader.readAsText(file);

- }, function(error) {

- chrome.test.fail('Unable to get file snapshot: ' + error.name);

- });

+ },

+ chrome.test.fail.bind(null, 'Unable to get file snapshot.'));

}

/**

« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/file_browser/drive_search_test/test.js » ('j') | no next file with comments »