[Media Router] Unit tests for sticky cast modes

[Media Router] Unit tests for sticky cast modes

This CL adds test cases to MediaRouterUITest and
MediaRouterWebUIMessageHandlerTest that test recording and retrieving users'
preferred cast modes (whether they chose tab mirroring for the current origin)
in regular and incognito profiles.

BUG=664671
Committed: https://crrev.com/a600d8d8827e214ea10131ce041419118abaec30
Cr-Commit-Position: refs/heads/master@{#440908}

[takumif, 2016-12-06 00:16:06]

Description was changed from

==========
.

BUG=
==========

to

==========
[Media Router] Don't record/retrieve cast mode pref in incognito

When the user is in incognito mode, we shouldn't record their cast mode
selections in the MR dialog. We also shouldn't change the initial cast mode
based on user pref in incognito.

BUG=664671
==========

[takumif, 2016-12-06 00:17:21]

Description was changed from

==========
[Media Router] Don't record/retrieve cast mode pref in incognito

When the user is in incognito mode, we shouldn't record their cast mode
selections in the MR dialog. We also shouldn't change the initial cast mode
based on user pref in incognito.

BUG=664671
==========

to

==========
[Media Router] Don't record/retrieve cast mode pref in incognito

When the user is in incognito mode, we shouldn't record their cast mode
selections in the MR dialog. We also shouldn't change the initial cast mode
based on user pref in incognito.

BUG=664671
==========

[takumif, 2016-12-06 00:24:21]

takumif@chromium.org changed reviewers:
+ apacible@chromium.org

[takumif, 2016-12-06 00:24:22]

Please take a look, thank you!

[apacible, 2016-12-06 21:30:58]

lgtm

[takumif, 2016-12-06 22:57:00]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 22:58:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 23:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 23:04:18]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[takumif, 2016-12-06 23:18:28]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 23:19:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 23:29:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 23:29:30]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[takumif, 2016-12-07 00:12:48]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 00:13:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:49:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:49:41]

Dry run: This issue passed the CQ dry run.

[takumif, 2016-12-09 20:27:55]

Patchset #3 (id:40001) has been deleted

[takumif, 2016-12-09 20:33:34]

Patchset #3 (id:60001) has been deleted

[takumif, 2016-12-12 20:16:29]

Patchset #3 (id:80001) has been deleted

[takumif, 2016-12-12 20:19:33]

Patchset #2 (id:20001) has been deleted

[takumif, 2016-12-12 20:26:06]

Description was changed from

==========
[Media Router] Don't record/retrieve cast mode pref in incognito

When the user is in incognito mode, we shouldn't record their cast mode
selections in the MR dialog. We also shouldn't change the initial cast mode
based on user pref in incognito.

BUG=664671
==========

to

==========
[Media Router] Unit tests for sticky cast modes

This CL adds test cases to MediaRouterUITest and
MediaRouterWebUIMessageHandlerTest that test recording and retrieving users'
preferred cast modes (whether they chose tab mirroring for the current origin)
in regular and incognito profiles.

BUG=664671
==========

[takumif, 2016-12-12 20:26:25]

Description was changed from

==========
[Media Router] Unit tests for sticky cast modes

This CL adds test cases to MediaRouterUITest and
MediaRouterWebUIMessageHandlerTest that test recording and retrieving users'
preferred cast modes (whether they chose tab mirroring for the current origin)
in regular and incognito profiles.

BUG=664671
==========

to

==========
[Media Router] Unit tests for sticky cast modes

This CL adds test cases to MediaRouterUITest and
MediaRouterWebUIMessageHandlerTest that test recording and retrieving users'
preferred cast modes (whether they chose tab mirroring for the current origin)
in regular and incognito profiles.

BUG=664671
==========

[takumif, 2016-12-12 20:33:54]

Since we took care of incognito cases in this CL [1], I've removed
incognito-related changes from this CL and modified the unit tests a bit. Please
take another look, thanks.

[1] https://codereview.chromium.org/2517833004/

[takumif, 2016-12-13 19:21:27]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 19:22:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 20:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:08:33]

Dry run: This issue passed the CQ dry run.

[takumif, 2016-12-28 20:31:53]

I've added a new patch set to this CL, so it'd be great if you could take a look
at this again. Thanks!

[apacible, 2016-12-28 22:07:39]

lgtm

[takumif, 2016-12-28 22:12:33]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 22:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 22:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 22:52:53]

Dry run: This issue passed the CQ dry run.

[takumif, 2016-12-28 22:53:58]

The CQ bit was checked by takumif@chromium.org

[commit-bot: I haz the power, 2016-12-28 22:54:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 22:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 22:57:35]

Failed to apply patch for
chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc:577
  error:
chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc:
patch does not apply

Patch:      
chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
Index:
chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
diff --git
a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
index
cc22450104a0b94dea07f0f8189c1ceac9046cc7..93b1925b804d68a9c2ec88bd98b1d031d0f8d703
100644
---
a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
+++
b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
@@ -15,6 +15,7 @@
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+using testing::Return;
 using testing::ReturnRef;
 
 namespace media_router {
@@ -30,6 +31,10 @@ class MockMediaRouterUI : public MediaRouterUI {
       : MediaRouterUI(web_ui) {}
   ~MockMediaRouterUI() {}
 
+  MOCK_METHOD0(UIInitialized, void());
+  MOCK_CONST_METHOD0(UserSelectedTabMirroringForCurrentOrigin, bool());
+  MOCK_METHOD1(RecordCastModeSelection, void(MediaCastMode cast_mode));
+  MOCK_CONST_METHOD0(cast_modes, const std::set<MediaCastMode>&());
   MOCK_CONST_METHOD0(GetRouteProviderExtensionId, const std::string&());
 };
 
@@ -577,4 +582,51 @@ TEST_F(MediaRouterWebUIMessageHandlerTest, UpdateIssue) {
   EXPECT_EQ(is_blocking, actual_is_blocking);
 }
 
+TEST_F(MediaRouterWebUIMessageHandlerTest, RecordCastModeSelection) {
+  base::ListValue args;
+  args.AppendInteger(MediaCastMode::DEFAULT);
+  EXPECT_CALL(*mock_media_router_ui_.get(),
+              RecordCastModeSelection(MediaCastMode::DEFAULT))
+      .Times(1);
+  handler_->OnReportSelectedCastMode(&args);
+
+  args.Clear();
+  args.AppendInteger(MediaCastMode::TAB_MIRROR);
+  EXPECT_CALL(*mock_media_router_ui_.get(),
+              RecordCastModeSelection(MediaCastMode::TAB_MIRROR))
+      .Times(1);
+  handler_->OnReportSelectedCastMode(&args);
+}
+
+TEST_F(MediaRouterWebUIMessageHandlerTest, RetrieveCastModeSelection) {
+  base::ListValue args;
+  std::set<MediaCastMode> cast_modes = {MediaCastMode::TAB_MIRROR};
+  EXPECT_CALL(*mock_media_router_ui_, GetRouteProviderExtensionId())
+      .WillRepeatedly(ReturnRef(provider_extension_id()));
+  EXPECT_CALL(*mock_media_router_ui_, cast_modes())
+      .WillRepeatedly(ReturnRef(cast_modes));
+
+  EXPECT_CALL(*mock_media_router_ui_,
+              UserSelectedTabMirroringForCurrentOrigin())
+      .WillOnce(Return(true));
+  handler_->OnRequestInitialData(&args);
+  const content::TestWebUI::CallData& call_data1 = *web_ui_->call_data()[0];
+  ASSERT_EQ("media_router.ui.setInitialData", call_data1.function_name());
+  const base::DictionaryValue* initial_data = nullptr;
+  ASSERT_TRUE(call_data1.arg1()->GetAsDictionary(&initial_data));
+  bool use_tab_mirroring = false;
+  EXPECT_TRUE(initial_data->GetBoolean("useTabMirroring", &use_tab_mirroring));
+  EXPECT_TRUE(use_tab_mirroring);
+
+  EXPECT_CALL(*mock_media_router_ui_,
+              UserSelectedTabMirroringForCurrentOrigin())
+      .WillOnce(Return(false));
+  handler_->OnRequestInitialData(&args);
+  const content::TestWebUI::CallData& call_data2 = *web_ui_->call_data()[1];
+  ASSERT_EQ("media_router.ui.setInitialData", call_data2.function_name());
+  ASSERT_TRUE(call_data2.arg1()->GetAsDictionary(&initial_data));
+  EXPECT_TRUE(initial_data->GetBoolean("useTabMirroring", &use_tab_mirroring));
+  EXPECT_FALSE(use_tab_mirroring);
+}
+
 }  // namespace media_router

[takumif, 2016-12-28 23:00:47]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 23:01:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 23:55:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 23:56:00]

Dry run: This issue passed the CQ dry run.

[takumif, 2016-12-28 23:58:05]

The CQ bit was checked by takumif@chromium.org

[takumif, 2016-12-28 23:58:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
apacible@chromium.org
Link to the patchset: https://codereview.chromium.org/2549323002/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-28 23:58:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 00:02:52]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1482969485891570,
"parent_rev": "72040f543b53b4e9151efc169d414219d7404dc1", "commit_rev":
"c421ae7020ed0e27dfcf2707942ada303c0da633"}

[commit-bot: I haz the power, 2016-12-29 00:03:19]

Description was changed from

==========
[Media Router] Unit tests for sticky cast modes

This CL adds test cases to MediaRouterUITest and
MediaRouterWebUIMessageHandlerTest that test recording and retrieving users'
preferred cast modes (whether they chose tab mirroring for the current origin)
in regular and incognito profiles.

BUG=664671
==========

to

==========
[Media Router] Unit tests for sticky cast modes

This CL adds test cases to MediaRouterUITest and
MediaRouterWebUIMessageHandlerTest that test recording and retrieving users'
preferred cast modes (whether they chose tab mirroring for the current origin)
in regular and incognito profiles.

BUG=664671

Review-Url: https://codereview.chromium.org/2549323002
==========

[commit-bot: I haz the power, 2016-12-29 00:03:19]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2017-01-02 15:50:50]

Description was changed from

==========
[Media Router] Unit tests for sticky cast modes

This CL adds test cases to MediaRouterUITest and
MediaRouterWebUIMessageHandlerTest that test recording and retrieving users'
preferred cast modes (whether they chose tab mirroring for the current origin)
in regular and incognito profiles.

BUG=664671

Review-Url: https://codereview.chromium.org/2549323002
==========

to

==========
[Media Router] Unit tests for sticky cast modes

This CL adds test cases to MediaRouterUITest and
MediaRouterWebUIMessageHandlerTest that test recording and retrieving users'
preferred cast modes (whether they chose tab mirroring for the current origin)
in regular and incognito profiles.

BUG=664671

Committed: https://crrev.com/a600d8d8827e214ea10131ce041419118abaec30
Cr-Commit-Position: refs/heads/master@{#440908}
==========

[commit-bot: I haz the power, 2017-01-02 15:50:51]

Patchset 4 (id:??) landed as
https://crrev.com/a600d8d8827e214ea10131ce041419118abaec30
Cr-Commit-Position: refs/heads/master@{#440908}