Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui.h

Issue 2549323002: [Media Router] Unit tests for sticky cast modes (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/media_router/media_router_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/media_router/media_router_ui.h
diff --git a/chrome/browser/ui/webui/media_router/media_router_ui.h b/chrome/browser/ui/webui/media_router/media_router_ui.h
index e8e2901c0e42e8527f79dc0b31fe898379245e8e..1f505b24bdd1e159987111c3e25a1c71a4c280d7 100644
--- a/chrome/browser/ui/webui/media_router/media_router_ui.h
+++ b/chrome/browser/ui/webui/media_router/media_router_ui.h
@@ -95,8 +95,9 @@ class MediaRouterUI : public ConstrainedWebDialogUI,
// Closes the media router UI.
void Close();
- // Notifies this instance that the UI has been initialized.
- void UIInitialized();
+ // Notifies this instance that the UI has been initialized. Marked virtual for
+ // tests.
+ virtual void UIInitialized();
// Requests a route be created from the source mapped to
// |cast_mode|, to the sink given by |sink_id|.
@@ -127,12 +128,12 @@ class MediaRouterUI : public ConstrainedWebDialogUI,
MediaCastMode cast_mode);
// Returns true if the cast mode last chosen for the current origin is tab
- // mirroring.
- bool UserSelectedTabMirroringForCurrentOrigin() const;
+ // mirroring. Marked virtual for tests.
+ virtual bool UserSelectedTabMirroringForCurrentOrigin() const;
// Records the cast mode selection for the current origin, unless the cast
- // mode is MediaCastMode::DESKTOP_MIRROR.
- void RecordCastModeSelection(MediaCastMode cast_mode);
+ // mode is MediaCastMode::DESKTOP_MIRROR. Marked virtual for tests.
+ virtual void RecordCastModeSelection(MediaCastMode cast_mode);
// Returns the hostname of the default source's parent frame URL.
std::string GetPresentationRequestSourceName() const;
@@ -145,7 +146,8 @@ class MediaRouterUI : public ConstrainedWebDialogUI,
const std::vector<MediaRoute::Id>& joinable_route_ids() const {
return joinable_route_ids_;
}
- const std::set<MediaCastMode>& cast_modes() const { return cast_modes_; }
+ // Marked virtual for tests.
+ virtual const std::set<MediaCastMode>& cast_modes() const;
const std::unordered_map<MediaRoute::Id, MediaCastMode>&
routes_and_cast_modes() const {
return routes_and_cast_modes_;
« no previous file with comments | « no previous file | chrome/browser/ui/webui/media_router/media_router_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698