Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: net/http/http_util.h

Issue 2549143003: Cleaned up the API of HttpUtil::ParseContentRangeHeader(). (Closed)
Patch Set: Initial patch set Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_util.h
diff --git a/net/http/http_util.h b/net/http/http_util.h
index fe68423f6085473cd8af01f4bcbae363c063d308..d35a2fcc4b640886030a55caff1d6941f339259e 100644
--- a/net/http/http_util.h
+++ b/net/http/http_util.h
@@ -60,16 +60,13 @@ class NET_EXPORT HttpUtil {
static bool ParseRangeHeader(const std::string& range_specifier,
std::vector<HttpByteRange>* ranges);
- // Extracts the values in a Content-Range header and returns true if they are
- // valid for a 206 response; otherwise returns false.
+ // Extracts the values in a Content-Range header and returns true if all three
+ // values are present and valid for a 206 response; otherwise returns false.
// The following values will be outputted:
// |*first_byte_position| = inclusive position of the first byte of the range
// |*last_byte_position| = inclusive position of the last byte of the range
// |*instance_length| = size in bytes of the object requested
- // If any of the above values is unknown, its value will be -1.
- // TODO(sclittle): Change this method to only support Content-Range headers
- // from 206 responses, since right now it only has incomplete support for
- // Content-Range headers from 416 responses. See crbug.com/670913.
+ // If this method returns false, then all of the outputs will be -1.
static bool ParseContentRangeHeader(base::StringPiece content_range_spec,
int64_t* first_byte_position,
int64_t* last_byte_position,

Powered by Google App Engine
This is Rietveld 408576698