Cleaned up the API of HttpUtil::ParseContentRangeHeader().

net/http/http_response_headers.h

Index: net/http/http_response_headers.h
diff --git a/net/http/http_response_headers.h b/net/http/http_response_headers.h
index 39404cfd9f2f444bb281a67db454651107b4e770..67c06f1ef8c9cecb2c1e415b5285f63ecd3ccc30 100644
--- a/net/http/http_response_headers.h
+++ b/net/http/http_response_headers.h
@@ -292,13 +292,13 @@ class NET_EXPORT HttpResponseHeaders
   // such header in the response.
   int64_t GetInt64HeaderValue(const std::string& header) const;
 
-  // Extracts the values in a Content-Range header and returns true if they are
-  // valid for a 206 response; otherwise returns false.
+  // Extracts the values in a Content-Range header and returns true if all three
+  // values are present and valid for a 206 response; otherwise returns false.
   // The following values will be outputted:
   // |*first_byte_position| = inclusive position of the first byte of the range
   // |*last_byte_position| = inclusive position of the last byte of the range
   // |*instance_length| = size in bytes of the object requested
-  // If any of the above values is unknown, its value will be -1.
+  // If this method returns false, then all of the outputs will be -1.
   bool GetContentRange(int64_t* first_byte_position,

[mmenke, 2016/12/06 19:18:06]

Maybe rename to GetContentRangeFor206, and same for the other one?  That will
require updating all callsites, but that also forces the change in front of all
consumers, and they can sanity check the change (Yes, it looks fine, but I'm
paranoid, and could imagine breaking external embedders as well)

[sclittle, 2016/12/08 20:37:55]

Done.

                        int64_t* last_byte_position,
                        int64_t* instance_length) const;