Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: net/http/http_response_headers_unittest.cc

Issue 2549143003: Cleaned up the API of HttpUtil::ParseContentRangeHeader(). (Closed)
Patch Set: Initial patch set Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_response_headers_unittest.cc
diff --git a/net/http/http_response_headers_unittest.cc b/net/http/http_response_headers_unittest.cc
index 041972b76df1edda20c64a541f6dbaa6a926c12b..a39ffa3f8c938801462a4fe4fda5cb123c88a5d4 100644
--- a/net/http/http_response_headers_unittest.cc
+++ b/net/http/http_response_headers_unittest.cc
@@ -1363,99 +1363,16 @@ const ContentRangeTestData content_range_tests[] = {
"Content-Range:",
false, -1, -1, -1},
{"HTTP/1.1 206 Partial Content\n"
- "Content-Range: megabytes 0-10/50",
- false, -1, -1, -1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: 0-10/50",
- false, -1, -1, -1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: Bytes 0-50/51",
- true, 0, 50, 51},
- {"HTTP/1.1 206 Partial Content\n"
"Content-Range: bytes 0-50/51",
true, 0, 50, 51},
{"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes\t0-50/51",
- false, -1, -1, -1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0-50/51",
- true, 0, 50, 51},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0 - 50 \t / \t51",
- true, 0, 50, 51},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0\t-\t50\t/\t51\t",
- true, 0, 50, 51},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: \tbytes\t\t\t 0\t-\t50\t/\t51\t",
- true, 0, 50, 51},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: \t bytes \t 0 - 50 / 5 1",
- false, 0, 50, -1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: \t bytes \t 0 - 5 0 / 51",
- false, -1, -1, -1},
- {"HTTP/1.1 206 Partial Content\n"
"Content-Range: bytes 50-0/51",
- false, 50, 0, -1},
- {"HTTP/1.1 416 Requested range not satisfiable\n"
- "Content-Range: bytes * /*",
false, -1, -1, -1},
{"HTTP/1.1 416 Requested range not satisfiable\n"
- "Content-Range: bytes * / * ",
+ "Content-Range: bytes */*",
false, -1, -1, -1},
{"HTTP/1.1 206 Partial Content\n"
"Content-Range: bytes 0-50/*",
- false, 0, 50, -1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0-50 / * ",
- false, 0, 50, -1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0-10000000000/10000000001",
- true, 0, 10000000000ll, 10000000001ll},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0-10000000000/10000000000",
- false, 0, 10000000000ll, 10000000000ll},
- // 64 bit wraparound.
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0 - 9223372036854775807 / 100",
- false, 0, std::numeric_limits<int64_t>::max(), 100},
- // 64 bit wraparound.
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0 - 100 / -9223372036854775808",
- false, 0, 100, std::numeric_limits<int64_t>::min()},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes */50",
- false, -1, -1, 50},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0-50/10",
- false, 0, 50, 10},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 40-50/45",
- false, 40, 50, 45},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0-50/-10",
- false, 0, 50, -10},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0-0/1",
- true, 0, 0, 1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0-40000000000000000000/40000000000000000001",
- false, -1, -1, -1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 1-/100",
- false, -1, -1, -1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes -/100",
- false, -1, -1, -1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes -1/100",
- false, -1, -1, -1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes 0-1233/*",
- false, 0, 1233, -1},
- {"HTTP/1.1 206 Partial Content\n"
- "Content-Range: bytes -123 - -1/100",
false, -1, -1, -1},
};

Powered by Google App Engine
This is Rietveld 408576698