[MD History] Color tweaks.

[MD History] Color tweaks.

This CL fixes some colors in MD History that were low contrast. It also
makes a bunch of colors consistent and pulls most colors into
shared_vars.html so we can better manage our vast color spectrum.

BUG=670836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/25fffa4d6c9d5260260e82f93d18e086ab2b058d
Cr-Commit-Position: refs/heads/master@{#438073}

[calamity, 2016-12-06 03:15:51]

Description was changed from

==========
[MD History] Color tweaks.

This CL fixes some colors in MD History that were low contrast. It also
makes a bunch of colors consistent and pulls most colors into
shared_vars.html so we can better manage our vast color spectrum.

BUG=670836
==========

to

==========
[MD History] Color tweaks.

This CL fixes some colors in MD History that were low contrast. It also
makes a bunch of colors consistent and pulls most colors into
shared_vars.html so we can better manage our vast color spectrum.

BUG=670836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-12-06 03:35:40]

Patchset #1 (id:1) has been deleted

[calamity, 2016-12-06 03:45:33]

Patchset #1 (id:20001) has been deleted

[calamity, 2016-12-06 03:46:50]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[calamity, 2016-12-06 03:46:50]

--google-blue da ba di da ba dai

[tsergeant, 2016-12-06 06:45:00]

All this talk of colors has me thinking about my new bike shed...

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.html (right):

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/app.html:19: :host {
More idea stealing from settings: Put

color: var(--primary-text-color) 

in here. This will be inherited by everything, and we'll only need to color
things which aren't the default.

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:90: color:
var(--synced-devices-notice-color);
This dropdown also has a link in it. Can you make sure it's styled consistently
(it's currently not, whoops).

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_vars.html (right):

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_vars.html:18: --drawer-header-color:
#666;
This used to be rgb(66, 66, 66)

aka #424242,

aka --google-grey-800.

Was this a deliberate change?

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_vars.html:22: --primary-text-color:
#333;
Here's where it gets interesting: Primary color, according to the Settings
specs, should be #424242 (--paper-grey-800). Both History and Bookmarks specs
currently say #333, though.

I have no idea whether this is a deliberate difference. We should check.

If it's -not- a deliberate difference, we can consolidate a couple of other
things under --primary-text-color.

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_vars.html:26:
--sidebar-footer-link-color: var(--google-blue-700);
Again, referring to the settings spec, --google-blue-700 is the general link
color. Can we consolidate --sidebar-footer-link-color and
--sidebar-selected-color into a single variable like --link-color?

(Settings also applies this color to all <a> tags in their shared CSS module)

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_vars.html:33:
--toolbar-selected-color: rgb(68, 136, 255);
This is --google-blue-500

(aka --checked-color)

which, according to the settings spec is the general color for interactive
elements like toggles and buttons.

Can we consolidate this down into something like --interactive-color?

[calamity, 2016-12-08 06:36:34]

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.html (right):

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/app.html:19: :host {
On 2016/12/06 06:45:00, tsergeant wrote:
> More idea stealing from settings: Put
> 
> color: var(--primary-text-color) 
> 
> in here. This will be inherited by everything, and we'll only need to color
> things which aren't the default.

Done.

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:90: color:
var(--synced-devices-notice-color);
On 2016/12/06 06:45:00, tsergeant wrote:
> This dropdown also has a link in it. Can you make sure it's styled
consistently
> (it's currently not, whoops).

Covered by the a selector added to shared_style.html.

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_vars.html (right):

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_vars.html:18: --drawer-header-color:
#666;
On 2016/12/06 06:45:00, tsergeant wrote:
> This used to be rgb(66, 66, 66)
> 
> aka #424242,
> 
> aka --google-grey-800.
> 
> Was this a deliberate change?

Ooooops.

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_vars.html:22: --primary-text-color:
#333;
On 2016/12/06 06:45:00, tsergeant wrote:
> Here's where it gets interesting: Primary color, according to the Settings
> specs, should be #424242 (--paper-grey-800). Both History and Bookmarks specs
> currently say #333, though.
> 
> I have no idea whether this is a deliberate difference. We should check.
> 
> If it's -not- a deliberate difference, we can consolidate a couple of other
> things under --primary-text-color.

Sent an email.

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_vars.html:26:
--sidebar-footer-link-color: var(--google-blue-700);
On 2016/12/06 06:45:00, tsergeant wrote:
> Again, referring to the settings spec, --google-blue-700 is the general link
> color. Can we consolidate --sidebar-footer-link-color and
> --sidebar-selected-color into a single variable like --link-color?
> 
> (Settings also applies this color to all <a> tags in their shared CSS module)

Done.

https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_vars.html:33:
--toolbar-selected-color: rgb(68, 136, 255);
On 2016/12/06 06:45:00, tsergeant wrote:
> This is --google-blue-500
> 
> (aka --checked-color)
> 
> which, according to the settings spec is the general color for interactive
> elements like toggles and buttons.
> 
> Can we consolidate this down into something like --interactive-color?

Done.

[tsergeant, 2016-12-08 22:43:25]

lookin' good

https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_item.html (right):

https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/history_item.html:19: --checked-color:
var(--interactive-color);
Is it worth just using --interactive-color directly below?

https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_vars.html (right):

https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_vars.html:19: --drawer-header-color:
var(--paper-grey-800);
Since --primary-text-color should be --paper-grey-800, these can be consolidated
down.

[calamity, 2016-12-12 04:42:07]

https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_item.html (right):

https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/history_item.html:19: --checked-color:
var(--interactive-color);
On 2016/12/08 22:43:25, tsergeant wrote:
> Is it worth just using --interactive-color directly below?

Done.

https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/shared_vars.html (right):

https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/shared_vars.html:19: --drawer-header-color:
var(--paper-grey-800);
On 2016/12/08 22:43:25, tsergeant wrote:
> Since --primary-text-color should be --paper-grey-800, these can be
consolidated
> down.

Done.

[tsergeant, 2016-12-12 06:11:10]

lgtm!

[calamity, 2016-12-13 01:58:07]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 01:58:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2016-12-13 02:30:05]

The CQ bit was unchecked by calamity@chromium.org

[calamity, 2016-12-13 02:31:44]

calamity@chromium.org changed reviewers:
+ dbeam@chromium.org

[calamity, 2016-12-13 02:31:45]

+dbeam for md_downloads and ui/webui OWNERS.

PTAL, thanks.

[Dan Beam, 2016-12-13 04:02:35]

lgtm

https://codereview.chromium.org/2549133003/diff/100001/ui/webui/resources/css...
File ui/webui/resources/css/md_colors.css (right):

https://codereview.chromium.org/2549133003/diff/100001/ui/webui/resources/css...
ui/webui/resources/css/md_colors.css:12: --md-loading-message-color: #6e6e6e;
nit: alphabetize

[calamity, 2016-12-13 04:49:50]

Patchset #5 (id:120001) has been deleted

[calamity, 2016-12-13 04:50:18]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-12-13 04:50:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2549133003/#ps140001
(title: "fixnit")

[calamity, 2016-12-13 04:50:39]

https://codereview.chromium.org/2549133003/diff/100001/ui/webui/resources/css...
File ui/webui/resources/css/md_colors.css (right):

https://codereview.chromium.org/2549133003/diff/100001/ui/webui/resources/css...
ui/webui/resources/css/md_colors.css:12: --md-loading-message-color: #6e6e6e;
On 2016/12/13 04:02:34, Dan Beam wrote:
> nit: alphabetize

Done.

[commit-bot: I haz the power, 2016-12-13 04:50:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 06:05:14]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1481604618119250,
"parent_rev": "153a621920aeee48149e773b858f938bc534a612", "commit_rev":
"56bfffe7253d96b35607bb00a62c417fa3ee120b"}

[commit-bot: I haz the power, 2016-12-13 06:06:34]

Description was changed from

==========
[MD History] Color tweaks.

This CL fixes some colors in MD History that were low contrast. It also
makes a bunch of colors consistent and pulls most colors into
shared_vars.html so we can better manage our vast color spectrum.

BUG=670836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Color tweaks.

This CL fixes some colors in MD History that were low contrast. It also
makes a bunch of colors consistent and pulls most colors into
shared_vars.html so we can better manage our vast color spectrum.

BUG=670836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2549133003
==========

[commit-bot: I haz the power, 2016-12-13 06:06:37]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-12-13 06:10:55]

Description was changed from

==========
[MD History] Color tweaks.

This CL fixes some colors in MD History that were low contrast. It also
makes a bunch of colors consistent and pulls most colors into
shared_vars.html so we can better manage our vast color spectrum.

BUG=670836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2549133003
==========

to

==========
[MD History] Color tweaks.

This CL fixes some colors in MD History that were low contrast. It also
makes a bunch of colors consistent and pulls most colors into
shared_vars.html so we can better manage our vast color spectrum.

BUG=670836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/25fffa4d6c9d5260260e82f93d18e086ab2b058d
Cr-Commit-Position: refs/heads/master@{#438073}
==========

[commit-bot: I haz the power, 2016-12-13 06:10:56]

Patchset 5 (id:??) landed as
https://crrev.com/25fffa4d6c9d5260260e82f93d18e086ab2b058d
Cr-Commit-Position: refs/heads/master@{#438073}