Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2549133003: [MD History] Color tweaks. (Closed)

Created:
4 years ago by calamity
Modified:
4 years ago
Reviewers:
tsergeant, Dan Beam
CC:
chromium-reviews, asanka, dbeam+watch-elements_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-downloads_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Color tweaks. This CL fixes some colors in MD History that were low contrast. It also makes a bunch of colors consistent and pulls most colors into shared_vars.html so we can better manage our vast color spectrum. BUG=670836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/25fffa4d6c9d5260260e82f93d18e086ab2b058d Cr-Commit-Position: refs/heads/master@{#438073}

Patch Set 1 : #

Total comments: 12

Patch Set 2 : address comments #

Total comments: 4

Patch Set 3 : address comments #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : fixnit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -74 lines) Patch
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/app.html View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 2 3 4 32 chunks +63 lines, -36 lines 0 comments Download
M chrome/browser/resources/md_history/grouped_list.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 2 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 2 3 8 chunks +18 lines, -10 lines 0 comments Download
M chrome/browser/resources/md_history/shared_style.html View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/shared_vars.html View 1 2 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.html View 1 5 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/css/md_colors.css View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 26 (14 generated)
calamity
--google-blue da ba di da ba dai
4 years ago (2016-12-06 03:46:50 UTC) #5
tsergeant
All this talk of colors has me thinking about my new bike shed... https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resources/md_history/app.html File ...
4 years ago (2016-12-06 06:45:00 UTC) #6
calamity
https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resources/md_history/app.html File chrome/browser/resources/md_history/app.html (right): https://codereview.chromium.org/2549133003/diff/40001/chrome/browser/resources/md_history/app.html#newcode19 chrome/browser/resources/md_history/app.html:19: :host { On 2016/12/06 06:45:00, tsergeant wrote: > More ...
4 years ago (2016-12-08 06:36:34 UTC) #7
tsergeant
lookin' good https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resources/md_history/history_item.html File chrome/browser/resources/md_history/history_item.html (right): https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resources/md_history/history_item.html#newcode19 chrome/browser/resources/md_history/history_item.html:19: --checked-color: var(--interactive-color); Is it worth just using ...
4 years ago (2016-12-08 22:43:25 UTC) #8
calamity
https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resources/md_history/history_item.html File chrome/browser/resources/md_history/history_item.html (right): https://codereview.chromium.org/2549133003/diff/60001/chrome/browser/resources/md_history/history_item.html#newcode19 chrome/browser/resources/md_history/history_item.html:19: --checked-color: var(--interactive-color); On 2016/12/08 22:43:25, tsergeant wrote: > Is ...
4 years ago (2016-12-12 04:42:07 UTC) #9
tsergeant
lgtm!
4 years ago (2016-12-12 06:11:10 UTC) #10
calamity
+dbeam for md_downloads and ui/webui OWNERS. PTAL, thanks.
4 years ago (2016-12-13 02:31:45 UTC) #15
Dan Beam
lgtm https://codereview.chromium.org/2549133003/diff/100001/ui/webui/resources/css/md_colors.css File ui/webui/resources/css/md_colors.css (right): https://codereview.chromium.org/2549133003/diff/100001/ui/webui/resources/css/md_colors.css#newcode12 ui/webui/resources/css/md_colors.css:12: --md-loading-message-color: #6e6e6e; nit: alphabetize
4 years ago (2016-12-13 04:02:35 UTC) #16
calamity
https://codereview.chromium.org/2549133003/diff/100001/ui/webui/resources/css/md_colors.css File ui/webui/resources/css/md_colors.css (right): https://codereview.chromium.org/2549133003/diff/100001/ui/webui/resources/css/md_colors.css#newcode12 ui/webui/resources/css/md_colors.css:12: --md-loading-message-color: #6e6e6e; On 2016/12/13 04:02:34, Dan Beam wrote: > ...
4 years ago (2016-12-13 04:50:39 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549133003/140001
4 years ago (2016-12-13 04:50:40 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:140001)
4 years ago (2016-12-13 06:06:37 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-13 06:10:56 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/25fffa4d6c9d5260260e82f93d18e086ab2b058d
Cr-Commit-Position: refs/heads/master@{#438073}

Powered by Google App Engine
This is Rietveld 408576698