chrome/browser/resources/md_history/shared_vars.html - Issue 2549133003: [MD History] Color tweaks.

Side by Side Diff: chrome/browser/resources/md_history/shared_vars.html

Issue 2549133003: [MD History] Color tweaks. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/resources/md_history/history_toolbar.html ('K') | « chrome/browser/resources/md_history/shared_style.html ('k') | chrome/browser/resources/md_history/side_bar.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">

	2

1 <style is="custom-style">	3 <style is="custom-style">

2 :root {	4 :root {

3 --card-border-color: rgba(0, 0, 0, 0.14);	5 --card-border-color: rgba(0, 0, 0, 0.14);

4 --card-first-last-item-padding: 8px;	6 --card-first-last-item-padding: 8px;

5 --card-max-width: 960px;	7 --card-max-width: 960px;

6 --card-min-width: 550px;	8 --card-min-width: 550px;

7 --card-padding-between: 16px;	9 --card-padding-between: 16px;

8 --card-padding-side: 24px;	10 --card-padding-side: 24px;

9 --card-sizing: {	11 --card-sizing: {

10 margin: 0 auto;	12 margin: 0 auto;

11 max-width: var(--card-max-width);	13 max-width: var(--card-max-width);

12 min-width: var(--card-min-width);	14 min-width: var(--card-min-width);

13 padding: 0 var(--card-padding-side);	15 padding: 0 var(--card-padding-side);

14 width: calc(100% - 2 * var(--card-padding-side));	16 width: calc(100% - 2 * var(--card-padding-side));

15 };	17 };

	18 --drawer-header-color: #666;
	tsergeant 2016/12/06 06:45:00 This used to be rgb(66, 66, 66) aka #424242, aka This used to be rgb(66, 66, 66) aka #424242, aka --google-grey-800. Was this a deliberate change? calamity 2016/12/08 06:36:34 Ooooops. Show quoted text On 2016/12/06 06:45:00, tsergeant wrote: > This used to be rgb(66, 66, 66) > > aka #424242, > > aka --google-grey-800. > > Was this a deliberate change? Ooooops.
16 --first-card-padding-top: 24px;	19 --first-card-padding-top: 24px;

	20 --history-item-time-color: #646464;

17 --item-height: 44px;	21 --item-height: 44px;

18 --primary-text-color: #333;	22 --primary-text-color: #333;
	tsergeant 2016/12/06 06:45:00 Here's where it gets interesting: Primary color, a Here's where it gets interesting: Primary color, according to the Settings specs, should be #424242 (--paper-grey-800). Both History and Bookmarks specs currently say #333, though. I have no idea whether this is a deliberate difference. We should check. If it's -not- a deliberate difference, we can consolidate a couple of other things under --primary-text-color. calamity 2016/12/08 06:36:34 Sent an email. Show quoted text On 2016/12/06 06:45:00, tsergeant wrote: > Here's where it gets interesting: Primary color, according to the Settings > specs, should be #424242 (--paper-grey-800). Both History and Bookmarks specs > currently say #333, though. > > I have no idea whether this is a deliberate difference. We should check. > > If it's -not- a deliberate difference, we can consolidate a couple of other > things under --primary-text-color. Sent an email.
19 --secondary-text-color: #757575;	23 --secondary-text-color: #757575;

	24 --separator-color: rgba(0, 0, 0, 0.08);

20 --side-bar-width: 256px;	25 --side-bar-width: 256px;

	26 --sidebar-footer-link-color: var(--google-blue-700);
	tsergeant 2016/12/06 06:45:00 Again, referring to the settings spec, --google-bl Again, referring to the settings spec, --google-blue-700 is the general link color. Can we consolidate --sidebar-footer-link-color and --sidebar-selected-color into a single variable like --link-color? (Settings also applies this color to all <a> tags in their shared CSS module) calamity 2016/12/08 06:36:34 Done. Show quoted text On 2016/12/06 06:45:00, tsergeant wrote: > Again, referring to the settings spec, --google-blue-700 is the general link > color. Can we consolidate --sidebar-footer-link-color and > --sidebar-selected-color into a single variable like --link-color? > > (Settings also applies this color to all <a> tags in their shared CSS module) Done.
	27 --sidebar-footer-text-color: #6e6e6e;

	28 --sidebar-selected-color: var(--google-blue-700);

	29 --sidebar-unselected-color: #5a5a5a;

	30 --synced-devices-notice-color: var(--paper-grey-800);

21 --toolbar-grouped-height: 101px;	31 --toolbar-grouped-height: 101px;

22 --toolbar-height: 56px;	32 --toolbar-height: 56px;

	33 --toolbar-selected-color: rgb(68, 136, 255);
	tsergeant 2016/12/06 06:45:00 This is --google-blue-500 (aka --checked-color) This is --google-blue-500 (aka --checked-color) which, according to the settings spec is the general color for interactive elements like toggles and buttons. Can we consolidate this down into something like --interactive-color? calamity 2016/12/08 06:36:34 Done. Show quoted text On 2016/12/06 06:45:00, tsergeant wrote: > This is --google-blue-500 > > (aka --checked-color) > > which, according to the settings spec is the general color for interactive > elements like toggles and buttons. > > Can we consolidate this down into something like --interactive-color? Done.
23 }	34 }

24 </style>	35 </style>

OLD	NEW