mash/simple_wm/simple_wm.h - Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/simple_wm/simple_wm.h

Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior. (Closed)

Patch Set: Remove if condition statetment in Window::SetBounds(const gfx::Rect& new_bounds). Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mash/simple_wm/simple_wm.h

diff --git a/mash/simple_wm/simple_wm.h b/mash/simple_wm/simple_wm.h

index ac7042ca889a137e6e57703ff13aa6e59d133fc9..ea4aba6759250af5b921e8ac159284b945904948 100644

--- a/mash/simple_wm/simple_wm.h

+++ b/mash/simple_wm/simple_wm.h

@@ -66,7 +66,7 @@ class SimpleWM : public service_manager::Service,

// aura::WindowManagerDelegate:

void SetWindowManagerClient(aura::WindowManagerClient* client) override;

- bool OnWmSetBounds(aura::Window* window, gfx::Rect* bounds) override;

+ void OnWmSetBounds(aura::Window* window, const gfx::Rect& bounds) override;

bool OnWmSetProperty(

aura::Window* window,

const std::string& name,