Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2649)

Unified Diff: ash/mus/window_manager.cc

Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior. (Closed)
Patch Set: Remove if condition statetment in Window::SetBounds(const gfx::Rect& new_bounds). Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/mus/window_manager.cc
diff --git a/ash/mus/window_manager.cc b/ash/mus/window_manager.cc
index 53f0f6763bff8654f9cc087dcb2c7678d8efc7f6..7956210670b59c1640a94c1fdf49f6d67a30b057 100644
--- a/ash/mus/window_manager.cc
+++ b/ash/mus/window_manager.cc
@@ -371,12 +371,9 @@ void WindowManager::SetWindowManagerClient(aura::WindowManagerClient* client) {
window_manager_client_ = client;
}
-bool WindowManager::OnWmSetBounds(aura::Window* window, gfx::Rect* bounds) {
- // TODO(sky): this indirectly sets bounds, which is against what
- // OnWmSetBounds() recommends doing. Remove that restriction, or fix this.
- WmWindowMus::Get(window)->SetBounds(*bounds);
- *bounds = window->bounds();
- return true;
+void WindowManager::OnWmSetBounds(aura::Window* window,
+ const gfx::Rect& bounds) {
+ WmWindowMus::Get(window)->SetBounds(bounds);
}
bool WindowManager::OnWmSetProperty(

Powered by Google App Engine
This is Rietveld 408576698