Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: services/ui/public/cpp/window_manager_delegate.h

Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior. (Closed)
Patch Set: Remove if condition statetment in Window::SetBounds(const gfx::Rect& new_bounds). Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/public/cpp/window_manager_delegate.h
diff --git a/services/ui/public/cpp/window_manager_delegate.h b/services/ui/public/cpp/window_manager_delegate.h
index 51de4329f176f13a6af0d69432e57ddea6ce668a..67a12befe03a7e958d1ffd539c7855edb3ef2305 100644
--- a/services/ui/public/cpp/window_manager_delegate.h
+++ b/services/ui/public/cpp/window_manager_delegate.h
@@ -70,12 +70,8 @@ class WindowManagerDelegate {
// the WindowManager.
virtual void SetWindowManagerClient(WindowManagerClient* client) = 0;
- // A client requested the bounds of |window| to change to |bounds|. Return
- // true if the bounds are allowed to change. A return value of false
- // indicates the change is not allowed.
- // NOTE: This should not change the bounds of |window|. Instead return the
- // bounds the window should be in |bounds|.
- virtual bool OnWmSetBounds(Window* window, gfx::Rect* bounds) = 0;
+ // Set window bounds.
mfomitchev 2016/12/08 20:44:23 Please elaborate on what this is actually supposed
+ virtual void OnWmSetBounds(Window* window, const gfx::Rect& bounds) = 0;
// A client requested the shared property named |name| to change to
// |new_data|. Return true to allow the change to |new_data|, false

Powered by Google App Engine
This is Rietveld 408576698