FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not HTMLFormControlsCol…

FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not HTMLFormControlsCollection.

Specification: https://html.spec.whatwg.org/multipage/forms.html#dom-fieldset-elements
Intent: https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/1WO1qyjG3GQ

* HTMLFormControlsCollection:
 Remove <fieldset> support

* HTMLCollection:
  Add support for FormControls collection rooted at <fieldset>.
  Note that some functions are used by HTMLFormControlsCollection too.

* Update tests
  Make sure RadioNodeList isn't used.
  Unlike HTMLFormControlsCollection, fieldset.elements doesn't have an exception
  for <input type=image> [1]. So elements.length increased.

[1] https://html.spec.whatwg.org/multipage/forms.html#dom-form-elements

BUG=665291
Committed: https://crrev.com/58c06a5f1b87ec32101c95e17f52189fed28158a
Cr-Commit-Position: refs/heads/master@{#435946}

[tkent, 2016-12-02 08:37:50]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 08:38:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-12-02 08:42:26]

Description was changed from

==========
FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not
HTMLFormControlsCollection.

BUG=665291
==========

to

==========
FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not
HTMLFormControlsCollection.

* HTMLFormControlsCollection:
 Remove <fieldset> support

* HTMLCollection:
  Add support for FormControls collection rooted at <fieldset>.
  Note that some functions are used by HTMLFormControlsCollection too.

* Update tests
  Make sure RadioNodeList isn't used.
  Unlike HTMLFormControlsCollection, fieldset.elements doesn't have an exception
  for <input type=image>.

Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/1WO1qyjG3GQ

BUG=665291
==========

[tkent, 2016-12-02 08:44:33]

Description was changed from

==========
FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not
HTMLFormControlsCollection.

* HTMLFormControlsCollection:
 Remove <fieldset> support

* HTMLCollection:
  Add support for FormControls collection rooted at <fieldset>.
  Note that some functions are used by HTMLFormControlsCollection too.

* Update tests
  Make sure RadioNodeList isn't used.
  Unlike HTMLFormControlsCollection, fieldset.elements doesn't have an exception
  for <input type=image>.

Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/1WO1qyjG3GQ

BUG=665291
==========

to

==========
FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not
HTMLFormControlsCollection.

* HTMLFormControlsCollection:
 Remove <fieldset> support

* HTMLCollection:
  Add support for FormControls collection rooted at <fieldset>.
  Note that some functions are used by HTMLFormControlsCollection too.

* Update tests
  Make sure RadioNodeList isn't used.
  Unlike HTMLFormControlsCollection, fieldset.elements doesn't have an exception
  for <input type=image>. So elements.length increased.

Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/1WO1qyjG3GQ

BUG=665291
==========

[tkent, 2016-12-02 08:46:38]

Description was changed from

==========
FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not
HTMLFormControlsCollection.

* HTMLFormControlsCollection:
 Remove <fieldset> support

* HTMLCollection:
  Add support for FormControls collection rooted at <fieldset>.
  Note that some functions are used by HTMLFormControlsCollection too.

* Update tests
  Make sure RadioNodeList isn't used.
  Unlike HTMLFormControlsCollection, fieldset.elements doesn't have an exception
  for <input type=image>. So elements.length increased.

Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/1WO1qyjG3GQ

BUG=665291
==========

to

==========
FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not
HTMLFormControlsCollection.

Specification:
https://html.spec.whatwg.org/multipage/forms.html#dom-fieldset-elements
Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/1WO1qyjG3GQ

* HTMLFormControlsCollection:
 Remove <fieldset> support

* HTMLCollection:
  Add support for FormControls collection rooted at <fieldset>.
  Note that some functions are used by HTMLFormControlsCollection too.

* Update tests
  Make sure RadioNodeList isn't used.
  Unlike HTMLFormControlsCollection, fieldset.elements doesn't have an exception
  for <input type=image> [1]. So elements.length increased.

[1] https://html.spec.whatwg.org/multipage/forms.html#dom-form-elements

BUG=665291
==========

[tkent, 2016-12-02 08:47:46]

tkent@chromium.org changed reviewers:
+ kochi@chromium.org

[tkent, 2016-12-02 08:47:46]

kochi@, would you review this please?

[kochi, 2016-12-02 09:15:19]

lgtm

https://codereview.chromium.org/2548453003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLCollection.cpp (right):

https://codereview.chromium.org/2548453003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLCollection.cpp:242: 
nit: no empty lines on L242 & L246?  (following the convention in this block)

[tkent, 2016-12-02 11:56:32]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 11:56:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-12-02 13:09:23]

https://codereview.chromium.org/2548453003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLCollection.cpp (right):

https://codereview.chromium.org/2548453003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLCollection.cpp:242: 
On 2016/12/02 at 09:15:19, kochi wrote:
> nit: no empty lines on L242 & L246?  (following the convention in this block)

Done.

[tkent, 2016-12-02 13:09:28]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2016-12-02 13:09:32]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-12-02 13:09:32]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/2548453003/#ps20001
(title: "blank lines")

[commit-bot: I haz the power, 2016-12-02 13:09:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 16:05:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480684172334670,
"parent_rev": "9212a582e49512afd02b6e55dae4c8d57abfd845", "commit_rev":
"c5fa67942ff8e7939e04f02586203b956a07d7cc"}

[commit-bot: I haz the power, 2016-12-02 16:05:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 16:08:55]

Description was changed from

==========
FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not
HTMLFormControlsCollection.

Specification:
https://html.spec.whatwg.org/multipage/forms.html#dom-fieldset-elements
Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/1WO1qyjG3GQ

* HTMLFormControlsCollection:
 Remove <fieldset> support

* HTMLCollection:
  Add support for FormControls collection rooted at <fieldset>.
  Note that some functions are used by HTMLFormControlsCollection too.

* Update tests
  Make sure RadioNodeList isn't used.
  Unlike HTMLFormControlsCollection, fieldset.elements doesn't have an exception
  for <input type=image> [1]. So elements.length increased.

[1] https://html.spec.whatwg.org/multipage/forms.html#dom-form-elements

BUG=665291
==========

to

==========
FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not
HTMLFormControlsCollection.

Specification:
https://html.spec.whatwg.org/multipage/forms.html#dom-fieldset-elements
Intent:
https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/1WO1qyjG3GQ

* HTMLFormControlsCollection:
 Remove <fieldset> support

* HTMLCollection:
  Add support for FormControls collection rooted at <fieldset>.
  Note that some functions are used by HTMLFormControlsCollection too.

* Update tests
  Make sure RadioNodeList isn't used.
  Unlike HTMLFormControlsCollection, fieldset.elements doesn't have an exception
  for <input type=image> [1]. So elements.length increased.

[1] https://html.spec.whatwg.org/multipage/forms.html#dom-form-elements

BUG=665291

Committed: https://crrev.com/58c06a5f1b87ec32101c95e17f52189fed28158a
Cr-Commit-Position: refs/heads/master@{#435946}
==========

[commit-bot: I haz the power, 2016-12-02 16:08:56]

Patchset 2 (id:??) landed as
https://crrev.com/58c06a5f1b87ec32101c95e17f52189fed28158a
Cr-Commit-Position: refs/heads/master@{#435946}