Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFieldSetElement.h

Issue 2548453003: FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not HTMLFormControlsCol… (Closed)
Patch Set: blank lines Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 11 matching lines...) Expand all
22 */ 22 */
23 23
24 #ifndef HTMLFieldSetElement_h 24 #ifndef HTMLFieldSetElement_h
25 #define HTMLFieldSetElement_h 25 #define HTMLFieldSetElement_h
26 26
27 #include "core/CoreExport.h" 27 #include "core/CoreExport.h"
28 #include "core/html/HTMLFormControlElement.h" 28 #include "core/html/HTMLFormControlElement.h"
29 29
30 namespace blink { 30 namespace blink {
31 31
32 class HTMLFormControlsCollection; 32 class HTMLCollection;
33 33
34 class CORE_EXPORT HTMLFieldSetElement final : public HTMLFormControlElement { 34 class CORE_EXPORT HTMLFieldSetElement final : public HTMLFormControlElement {
35 DEFINE_WRAPPERTYPEINFO(); 35 DEFINE_WRAPPERTYPEINFO();
36 36
37 public: 37 public:
38 static HTMLFieldSetElement* create(Document&, HTMLFormElement*); 38 static HTMLFieldSetElement* create(Document&, HTMLFormElement*);
39 DECLARE_VIRTUAL_TRACE(); 39 DECLARE_VIRTUAL_TRACE();
40 HTMLLegendElement* legend() const; 40 HTMLLegendElement* legend() const;
41 41 HTMLCollection* elements();
42 HTMLFormControlsCollection* elements();
43
44 const FormAssociatedElement::List& associatedElements() const;
45 42
46 protected: 43 protected:
47 void disabledAttributeChanged() override; 44 void disabledAttributeChanged() override;
48 45
49 private: 46 private:
50 HTMLFieldSetElement(Document&, HTMLFormElement*); 47 HTMLFieldSetElement(Document&, HTMLFormElement*);
51 48
52 bool isEnumeratable() const override { return true; } 49 bool isEnumeratable() const override { return true; }
53 bool supportsFocus() const override; 50 bool supportsFocus() const override;
54 LayoutObject* createLayoutObject(const ComputedStyle&) override; 51 LayoutObject* createLayoutObject(const ComputedStyle&) override;
55 const AtomicString& formControlType() const override; 52 const AtomicString& formControlType() const override;
56 bool recalcWillValidate() const override { return false; } 53 bool recalcWillValidate() const override { return false; }
57 int tabIndex() const final; 54 int tabIndex() const final;
58 bool matchesValidityPseudoClasses() const final; 55 bool matchesValidityPseudoClasses() const final;
59 bool isValidElement() final; 56 bool isValidElement() final;
60 void childrenChanged(const ChildrenChange&) override; 57 void childrenChanged(const ChildrenChange&) override;
61 bool areAuthorShadowsAllowed() const override { return false; } 58 bool areAuthorShadowsAllowed() const override { return false; }
62 bool isSubmittableElement() override; 59 bool isSubmittableElement() override;
63 bool alwaysCreateUserAgentShadowRoot() const override { return false; } 60 bool alwaysCreateUserAgentShadowRoot() const override { return false; }
64 61
65 static void invalidateDisabledStateUnder(Element&); 62 static void invalidateDisabledStateUnder(Element&);
66 void refreshElementsIfNeeded() const; 63 void refreshElementsIfNeeded() const;
64 const FormAssociatedElement::List& associatedElements() const;
67 65
66 // TODO(tkent): Remove m_associcatedElements.
68 mutable FormAssociatedElement::List m_associatedElements; 67 mutable FormAssociatedElement::List m_associatedElements;
69 // When dom tree is modified, we have to refresh the m_associatedElements 68 // When dom tree is modified, we have to refresh the m_associatedElements
70 // array. 69 // array.
71 mutable uint64_t m_documentVersion; 70 mutable uint64_t m_documentVersion;
72 }; 71 };
73 72
74 } // namespace blink 73 } // namespace blink
75 74
76 #endif // HTMLFieldSetElement_h 75 #endif // HTMLFieldSetElement_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCollection.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698