Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements.html

Issue 2548453003: FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not HTMLFormControlsCol… (Closed)
Patch Set: blank lines Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements.html
diff --git a/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements.html b/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements.html
index 5984958970aa63836d679e07a8e8f762f89c2cd9..1eb2f26859e3af9378c903eb57b66d169f14b7e5 100644
--- a/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements.html
+++ b/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements.html
@@ -46,7 +46,7 @@ container.innerHTML = '<form id=formElement> <fieldset id="fs">' +
var owner = document.getElementById('fs');
-shouldBe('owner.elements.length', '23');
+shouldBe('owner.elements.length', '24');
shouldBe('owner.elements[0].id', "'button1'");
shouldBe('owner.elements[1].id', "'fieldset1'");
shouldBe('owner.elements[2].id', "'inputhidden'");
@@ -63,13 +63,14 @@ shouldBe('owner.elements[12].id', "'inputcheckbox'");
shouldBe('owner.elements[13].id', "'inputradio'");
shouldBe('owner.elements[14].id', "'inputfile'");
shouldBe('owner.elements[15].id', "'inputsubmit'");
-shouldBe('owner.elements[16].id', "'inputreset'");
-shouldBe('owner.elements[17].id', "'inputbutton'");
-shouldBe('owner.elements[18].id', "'keygen1'");
-shouldBe('owner.elements[19].id', "'object1'");
-shouldBe('owner.elements[20].id', "'output1'");
-shouldBe('owner.elements[21].id', "'select1'");
-shouldBe('owner.elements[22].id', "'textarea1'");
+shouldBe('owner.elements[16].id', "'inputimage'");
+shouldBe('owner.elements[17].id', "'inputreset'");
+shouldBe('owner.elements[18].id', "'inputbutton'");
+shouldBe('owner.elements[19].id', "'keygen1'");
+shouldBe('owner.elements[20].id', "'object1'");
+shouldBe('owner.elements[21].id', "'output1'");
+shouldBe('owner.elements[22].id', "'select1'");
+shouldBe('owner.elements[23].id', "'textarea1'");
var newElement = document.createElement("input");
newElement.setAttribute("type", "text");
@@ -78,15 +79,15 @@ newElement.setAttribute("id", "inputcommon");
debug("");
debug("Check elements array is updated after adding a new element");
-shouldBe('owner.appendChild(newElement); owner.elements.length', '24');
+shouldBe('owner.appendChild(newElement); owner.elements.length', '25');
debug("");
debug("Check elements array is updated after remove an element");
-shouldBe('owner.removeChild(newElement); owner.elements.length', '23');
+shouldBe('owner.removeChild(newElement); owner.elements.length', '24');
debug("");
-debug("Check owner.elements is updated properly");
-shouldBe('document.getElementById("inputfile").type="image"; owner.elements.length', '22');
+debug("Check owner.elements is not updated by changing input type to image");
+shouldBe('document.getElementById("inputfile").type="image"; owner.elements.length', '24');
debug("");
debug("Check owner.elements is updated properly after removing from parent");
@@ -94,9 +95,9 @@ owner.parentNode.removeChild(owner);
var form = document.getElementById("formElement");
shouldBe('form.appendChild(newElement); form.elements.length', '1');
shouldBe('form.removeChild(newElement); form.elements.length', '0');
-shouldBe('owner.elements.length', '22');
-shouldBe('owner.appendChild(newElement); owner.elements.length', '23');
-shouldBe('owner.removeChild(newElement); owner.elements.length', '22');
+shouldBe('owner.elements.length', '24');
+shouldBe('owner.appendChild(newElement); owner.elements.length', '25');
+shouldBe('owner.removeChild(newElement); owner.elements.length', '24');
container.parentNode.removeChild(container);
</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-elements-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698