[WebAPKs] Compute the default scope from the manifest start URL.

[WebAPKs] Compute the default scope from the manifest start URL.

This CL changes how the scope is computed if the scope is unspecified in the
Android Manifest.
We used to compute the default scope based on the "URL the WebAPK navigates to
when launched." Deep links can open a WebAPK at an arbirtrary URL.
This CL changes the computation to be based on the Web Manifest start URL.

This change enables cleaning up
ManifestUpgradeDetectorFetcher#onDataAvailable(). We can now create the fetched
WebApkInfo using the current WebAPK's WebApkInfo#uri().

BUG=639536
Committed: https://crrev.com/cf064891c24ce454379b95b3a2a312b4e252c539
Cr-Commit-Position: refs/heads/master@{#437785}

[pkotwicz, 2016-12-08 03:47:45]

Description was changed from

==========
[WebAPKs] Do not "manifest URL" as "start URL" in
ManifestUpgradeDetectorFetcher#onDataAvailable()

WebApkInfo#create() takes two "start URL" parameters
- The Web Manifest start URL (WebApkInfo#manifestStartUrl()).
- The URL to load when the WebAPK is launched (WebApkInfo#uri()). This URL can
change from one
  WebAPK launch to the next depending on whether the WebAPK is launched from the
homescreen or from
  a deep link.

If the Web Manifest does not define a scope, we used to fall back to computing
the scope from the
"URL to load for the current WebAPK launch". This is bad because the


We used to set the default Web M

This CL switches Chrome to set the default value for the "Web Manifest scope"
based on the "Web Manifest start URL" instead of the "URL to load for the
current WebAPK launch".

BUG=
==========

to

==========
[WebAPKs] Do not "manifest URL" as "start URL" in
ManifestUpgradeDetectorFetcher#onDataAvailable()

This CL changes how the scope is computed if the scope is unspecified in the
Android Manifest.
We used to compute the default scope based on the "URL the WebAPK navigates to
when launched." Deep links can open a WebAPK at an arbirtrary URL.
This CL changes the computation to be based on the Web Manifest start URL.

This change enables cleaning up
ManifestUpgradeDetectorFetcher#onDataAvailable(). We can now create the fetched
WebApkInfo using the current WebAPK's WebApkInfo#uri().

BUG=639536
==========

[pkotwicz, 2016-12-08 03:47:45]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2016-12-08 03:51:43]

Dominick, can you please take a look?

This CL is based off of https://codereview.chromium.org/2460253002/

Its intent is to make the call to WebApkInfo#create() in
WebApkUpdateDataFetcher#onDataAvailable() more straightforward. This is the CL
that I promised that I would write in comment #35 in
https://codereview.chromium.org/2459023002

[dominickn, 2016-12-08 04:07:48]

Nit: the title and description are a bit grammatically incorrect.

[WebAPKs] Compute the default scope from the manifest start URL.

Otherwise lgtm

[pkotwicz, 2016-12-08 15:16:29]

Description was changed from

==========
[WebAPKs] Do not "manifest URL" as "start URL" in
ManifestUpgradeDetectorFetcher#onDataAvailable()

This CL changes how the scope is computed if the scope is unspecified in the
Android Manifest.
We used to compute the default scope based on the "URL the WebAPK navigates to
when launched." Deep links can open a WebAPK at an arbirtrary URL.
This CL changes the computation to be based on the Web Manifest start URL.

This change enables cleaning up
ManifestUpgradeDetectorFetcher#onDataAvailable(). We can now create the fetched
WebApkInfo using the current WebAPK's WebApkInfo#uri().

BUG=639536
==========

to

==========
[WebAPKs] Compute the default scope from the manifest start URL.

This CL changes how the scope is computed if the scope is unspecified in the
Android Manifest.
We used to compute the default scope based on the "URL the WebAPK navigates to
when launched." Deep links can open a WebAPK at an arbirtrary URL.
This CL changes the computation to be based on the Web Manifest start URL.

This change enables cleaning up
ManifestUpgradeDetectorFetcher#onDataAvailable(). We can now create the fetched
WebApkInfo using the current WebAPK's WebApkInfo#uri().

BUG=639536
==========

[pkotwicz, 2016-12-09 23:03:43]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-12-09 23:04:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 01:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 01:06:55]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[pkotwicz, 2016-12-11 02:19:16]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-12-11 02:19:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 02:58:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481422756434210,
"parent_rev": "6820947febbdeaa67ae5c02b539f4b5fb9a6f4ae", "commit_rev":
"589777323b6929ccfc65c5a7d4e660049cc3f0ce"}

[commit-bot: I haz the power, 2016-12-11 02:59:03]

Description was changed from

==========
[WebAPKs] Compute the default scope from the manifest start URL.

This CL changes how the scope is computed if the scope is unspecified in the
Android Manifest.
We used to compute the default scope based on the "URL the WebAPK navigates to
when launched." Deep links can open a WebAPK at an arbirtrary URL.
This CL changes the computation to be based on the Web Manifest start URL.

This change enables cleaning up
ManifestUpgradeDetectorFetcher#onDataAvailable(). We can now create the fetched
WebApkInfo using the current WebAPK's WebApkInfo#uri().

BUG=639536
==========

to

==========
[WebAPKs] Compute the default scope from the manifest start URL.

This CL changes how the scope is computed if the scope is unspecified in the
Android Manifest.
We used to compute the default scope based on the "URL the WebAPK navigates to
when launched." Deep links can open a WebAPK at an arbirtrary URL.
This CL changes the computation to be based on the Web Manifest start URL.

This change enables cleaning up
ManifestUpgradeDetectorFetcher#onDataAvailable(). We can now create the fetched
WebApkInfo using the current WebAPK's WebApkInfo#uri().

BUG=639536

Review-Url: https://codereview.chromium.org/2548333006
==========

[commit-bot: I haz the power, 2016-12-11 02:59:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-12 15:07:39]

Description was changed from

==========
[WebAPKs] Compute the default scope from the manifest start URL.

This CL changes how the scope is computed if the scope is unspecified in the
Android Manifest.
We used to compute the default scope based on the "URL the WebAPK navigates to
when launched." Deep links can open a WebAPK at an arbirtrary URL.
This CL changes the computation to be based on the Web Manifest start URL.

This change enables cleaning up
ManifestUpgradeDetectorFetcher#onDataAvailable(). We can now create the fetched
WebApkInfo using the current WebAPK's WebApkInfo#uri().

BUG=639536

Review-Url: https://codereview.chromium.org/2548333006
==========

to

==========
[WebAPKs] Compute the default scope from the manifest start URL.

This CL changes how the scope is computed if the scope is unspecified in the
Android Manifest.
We used to compute the default scope based on the "URL the WebAPK navigates to
when launched." Deep links can open a WebAPK at an arbirtrary URL.
This CL changes the computation to be based on the Web Manifest start URL.

This change enables cleaning up
ManifestUpgradeDetectorFetcher#onDataAvailable(). We can now create the fetched
WebApkInfo using the current WebAPK's WebApkInfo#uri().

BUG=639536

Committed: https://crrev.com/cf064891c24ce454379b95b3a2a312b4e252c539
Cr-Commit-Position: refs/heads/master@{#437785}
==========

[commit-bot: I haz the power, 2016-12-12 15:07:40]

Patchset 3 (id:??) landed as
https://crrev.com/cf064891c24ce454379b95b3a2a312b4e252c539
Cr-Commit-Position: refs/heads/master@{#437785}