Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3004)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java

Issue 2548333006: [WebAPKs] Compute the default scope from the manifest start URL. (Closed)
Patch Set: Merge branch 'update_fail_refactor0' into update_fail_refactor01 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcher.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
index 2a6cf5d038ef803eca0c7ff86461ac49b7021424..50ee188790495b72ce8d43137a0c104d7816a498 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
@@ -122,11 +122,20 @@ public class WebApkInfo extends WebappInfo {
String shortName, int displayMode, int orientation, int source, long themeColor,
long backgroundColor, String webApkPackageName, int shellApkVersion, String manifestUrl,
String manifestStartUrl, Map<String, String> iconUrlToMurmur2HashMap) {
- if (id == null || url == null || webApkPackageName == null) {
- Log.e(TAG, "Incomplete data provided: " + id + ", " + url + ", " + webApkPackageName);
+ if (id == null || url == null || manifestStartUrl == null || webApkPackageName == null) {
+ Log.e(TAG,
+ "Incomplete data provided: " + id + ", " + url + ", " + manifestStartUrl + ", "
+ + webApkPackageName);
return null;
}
+ // The default scope should be computed from the Web Manifest start URL. If the WebAPK was
+ // launched from a deep link {@link startUrl} may be different from the Web Manifest start
+ // URL.
+ if (TextUtils.isEmpty(scope)) {
+ scope = ShortcutHelper.getScopeFromUrl(manifestStartUrl);
+ }
+
return new WebApkInfo(id, url, scope, icon, name, shortName, displayMode,
orientation, source, themeColor, backgroundColor, webApkPackageName,
shellApkVersion, manifestUrl, manifestStartUrl, iconUrlToMurmur2HashMap);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcher.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698