Disable wdiff on Windows.

Disable wdiff on Windows.

The purpose of this is to see how many of the Windows hanging instances
are related to wdiff, and also perhaps separate the wdiff-related hangs
from any others.

BUG=637478
Committed: https://crrev.com/88fb1e82a1866e975526c93ca86482ee4e602547
Cr-Commit-Position: refs/heads/master@{#436512}

[qyearsley, 2016-12-06 01:20:15]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, tansell@chromium.org

[Dirk Pranke, 2016-12-06 01:46:26]

lgtm

[qyearsley, 2016-12-06 01:46:59]

https://codereview.chromium.org/2548303003/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py (right):

https://codereview.chromium.org/2548303003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py:233: return
None
Note, there are also other ways to disable wdiff temporarily, including changing
the place where it's invoked in the base Port class
(https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...),
let me know if there's a better way to do it than this :-)

[qyearsley, 2016-12-06 01:47:14]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 01:47:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-12-06 02:04:06]

On 2016/12/06 01:46:59, qyearsley wrote:
>
https://codereview.chromium.org/2548303003/diff/1/third_party/WebKit/Tools/Sc...
> File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
(right):
> 
>
https://codereview.chromium.org/2548303003/diff/1/third_party/WebKit/Tools/Sc...
> third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py:233: return
> None
> Note, there are also other ways to disable wdiff temporarily, including
changing
> the place where it's invoked in the base Port class
>
(https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...),
> let me know if there's a better way to do it than this :-)

That's right enough :).

[qyearsley, 2016-12-06 02:17:55]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2016-12-06 02:17:57]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-12-06 02:18:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mithro, 2016-12-06 02:23:17]

lgtm

[commit-bot: I haz the power, 2016-12-06 03:44:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480990677944990, "parent_rev":
"20454a4e6461fd5910c43342984bd9ac92af1c52", "commit_rev":
"fbd2f8d2714b7546eea0d7304b013678516fbd32"}

[commit-bot: I haz the power, 2016-12-06 03:44:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-06 03:46:28]

Description was changed from

==========
Disable wdiff on Windows.

The purpose of this is to see how many of the Windows hanging instances
are related to wdiff, and also perhaps separate the wdiff-related hangs
from any others.

BUG=637478
==========

to

==========
Disable wdiff on Windows.

The purpose of this is to see how many of the Windows hanging instances
are related to wdiff, and also perhaps separate the wdiff-related hangs
from any others.

BUG=637478

Committed: https://crrev.com/88fb1e82a1866e975526c93ca86482ee4e602547
Cr-Commit-Position: refs/heads/master@{#436512}
==========

[commit-bot: I haz the power, 2016-12-06 03:46:29]

Patchset 1 (id:??) landed as
https://crrev.com/88fb1e82a1866e975526c93ca86482ee4e602547
Cr-Commit-Position: refs/heads/master@{#436512}