Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (C) 2010 Google Inc. All rights reserved. | 1 # Copyright (C) 2010 Google Inc. All rights reserved. |
| 2 # | 2 # |
| 3 # Redistribution and use in source and binary forms, with or without | 3 # Redistribution and use in source and binary forms, with or without |
| 4 # modification, are permitted provided that the following conditions are | 4 # modification, are permitted provided that the following conditions are |
| 5 # met: | 5 # met: |
| 6 # | 6 # |
| 7 # * Redistributions of source code must retain the above copyright | 7 # * Redistributions of source code must retain the above copyright |
| 8 # notice, this list of conditions and the following disclaimer. | 8 # notice, this list of conditions and the following disclaimer. |
| 9 # * Redistributions in binary form must reproduce the above | 9 # * Redistributions in binary form must reproduce the above |
| 10 # copyright notice, this list of conditions and the following disclaimer | 10 # copyright notice, this list of conditions and the following disclaimer |
| (...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 220 | 220 |
| 221 def _path_to_crash_service(self): | 221 def _path_to_crash_service(self): |
| 222 binary_name = 'content_shell_crash_service.exe' | 222 binary_name = 'content_shell_crash_service.exe' |
| 223 return self._build_path(binary_name) | 223 return self._build_path(binary_name) |
| 224 | 224 |
| 225 def _path_to_image_diff(self): | 225 def _path_to_image_diff(self): |
| 226 binary_name = 'image_diff.exe' | 226 binary_name = 'image_diff.exe' |
| 227 return self._build_path(binary_name) | 227 return self._build_path(binary_name) |
| 228 | 228 |
| 229 def _path_to_wdiff(self): | 229 def _path_to_wdiff(self): |
| 230 return self.path_from_chromium_base('third_party', 'cygwin', 'bin', 'wdi ff.exe') | 230 # Temporarily disabling wdiff on Windows to see how this affects |
| 231 # the rate of layout test hanging on try bots (http://crbug.com/637478). | |
| 232 # TODO(qyearsley): Re-enable this when possible. | |
| 233 return None | |
|
qyearsley
2016/12/06 01:46:59
Note, there are also other ways to disable wdiff t
| |
| 231 | 234 |
| 232 def _check_crash_service_available(self): | 235 def _check_crash_service_available(self): |
| 233 """Checks whether the crash service binary is present.""" | 236 """Checks whether the crash service binary is present.""" |
| 234 result = self._check_file_exists(self._path_to_crash_service(), "content _shell_crash_service.exe") | 237 result = self._check_file_exists(self._path_to_crash_service(), "content _shell_crash_service.exe") |
| 235 if not result: | 238 if not result: |
| 236 _log.error(" Could not find crash service, unexpected crashes won 't be symbolized.") | 239 _log.error(" Could not find crash service, unexpected crashes won 't be symbolized.") |
| 237 _log.error(' Did you build the target blink_tests?') | 240 _log.error(' Did you build the target blink_tests?') |
| 238 _log.error('') | 241 _log.error('') |
| 239 return result | 242 return result |
| 240 | 243 |
| 241 def look_for_new_crash_logs(self, crashed_processes, start_time): | 244 def look_for_new_crash_logs(self, crashed_processes, start_time): |
| 242 if self.get_option('disable_breakpad'): | 245 if self.get_option('disable_breakpad'): |
| 243 return None | 246 return None |
| 244 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time) | 247 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time) |
| 245 | 248 |
| 246 def clobber_old_port_specific_results(self): | 249 def clobber_old_port_specific_results(self): |
| 247 if not self.get_option('disable_breakpad'): | 250 if not self.get_option('disable_breakpad'): |
| 248 self._dump_reader.clobber_old_results() | 251 self._dump_reader.clobber_old_results() |
| OLD | NEW |