Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 2548303003: Disable wdiff on Windows. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
index bc8ec2a44b4bbadaa75a841f75a0b485e9656fdb..3494b999cabe97a4c527bc0377da9ce757b47b25 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
@@ -227,7 +227,10 @@ class WinPort(base.Port):
return self._build_path(binary_name)
def _path_to_wdiff(self):
- return self.path_from_chromium_base('third_party', 'cygwin', 'bin', 'wdiff.exe')
+ # Temporarily disabling wdiff on Windows to see how this affects
+ # the rate of layout test hanging on try bots (http://crbug.com/637478).
+ # TODO(qyearsley): Re-enable this when possible.
+ return None
qyearsley 2016/12/06 01:46:59 Note, there are also other ways to disable wdiff t
def _check_crash_service_available(self):
"""Checks whether the crash service binary is present."""
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698