Chromium Code Reviews Chromium Code Reviews
Issue 254803002:
Making webrtc video quality test page generic (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/test/data/webrtc/webrtc_video_quality_test.html |
| diff --git a/chrome/test/data/webrtc/webrtc_video_quality_test.html b/chrome/test/data/webrtc/webrtc_video_quality_test.html |
| index 258984dcf5e815d26ee345dce4652855c4f28dec..807a3bfd3bef75516f86250650955767a65dfce2 100644 |
| --- a/chrome/test/data/webrtc/webrtc_video_quality_test.html |
| +++ b/chrome/test/data/webrtc/webrtc_video_quality_test.html |
| @@ -9,7 +9,7 @@ |
| <script type="text/javascript" src="jsep01_call.js"></script> |
| <script type="text/javascript" src="video_extraction.js"></script> |
| </head> |
| -<body> |
| +<body onload="initialize()"> |
|
kjellander_chromium
2014/04/29 08:17:37
Make sure you remove this, since it will cause a J
amogh.bihani
2014/04/29 10:38:53
Done.
|
| <table border="0"> |
| <tr> |
| <td>Local Preview</td> |
| @@ -17,8 +17,7 @@ |
| </tr> |
| <tr> |
| <td> |
| - <video width="640" height="360" id="local-view" |
| - autoplay="autoplay"></video> |
| + <video id="local-view" autoplay="autoplay"></video> |
| </td> |
| <td> |
| <!-- startFrameCapture() takes 5 parameters: |
| @@ -27,20 +26,18 @@ |
| 3. canvas_height: Height of the canvas. |
| 4. fps: fps at which we would like to sample. |
| 5. duration: The duration of the capturing. --> |
| - <video width="640" height="360" id="remote-view" |
| - autoplay="autoplay" onplay="startFrameCapture(640,360,360,30,5)"> |
| - </video> |
| + <video id="remote-view" autoplay="autoplay" |
| + onplay="startFrameCapture('local-view', 30, 5)"></video> |
|
kjellander_chromium
2014/04/29 08:17:37
'local-view' here is wrong, it should be 'remote-v
phoglund_chromium
2014/04/29 08:48:20
Yeah, I missed that; good catch.
amogh.bihani
2014/04/29 10:38:53
Done.
|
| </td> |
| </tr> |
| <tr> |
| <td></td> |
| <td> |
| - <div id="output" style="display: inline-block; |
| - position: relative; width: 640; height: 360"> |
| + <div id="output"> |
| <!-- Canvas height should be equal to video height if we want to |
| capture the whole frames. If we only want to capture the barcode, |
| canvas height should equal the barcode height. --> |
| - <canvas id="remote-canvas" width="640" height="360"></canvas> |
| + <canvas id="remote-canvas"></canvas> |
|
kjellander_chromium
2014/04/29 08:17:37
Now that you remove the size of the canvas, does i
amogh.bihani
2014/04/29 10:38:53
I think this would work as first two frames are ne
kjellander_chromium
2014/04/29 11:28:16
I tried out your CL locally and it doesn't. The de
amogh.bihani
2014/04/29 11:43:02
I added the deps in gclient as mentioned in https:
|
| </div> |
| </td> |
| </tr> |
