[Chromecast] Use symbol_level=1 for 32-bit GCC toolchains.

[Chromecast] Use symbol_level=1 for 32-bit GCC toolchains.

When using 32-bit GCC toolchains on non-component builds, generated
artifacts are too big for 32-bit address space with full symbols. Force
users to either reduce the symbol level or use the component build.

BUG=670776
BUG=671624

[slan, 2016-12-02 20:01:06]

slan@chromium.org changed reviewers:
+ alokp@chromium.org, dpranke@chromium.org, mbjorge@chromium.org

[slan, 2016-12-02 20:01:06]

PTAL! 

+Dirk for OWNERS

[slan, 2016-12-02 20:01:13]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 20:01:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mbjorge, 2016-12-02 20:46:34]

lgtm

[commit-bot: I haz the power, 2016-12-02 21:17:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 21:17:55]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-12-02 22:43:45]

https://codereview.chromium.org/2547963002/diff/1/build/config/compiler/compi...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/2547963002/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:102: symbol_level = 1
It looks like you're hitting the same limitation Android is (see the
ignore_elf32_limitation block, below).

Can you merge the two together?

[slan, 2016-12-05 17:58:40]

On 2016/12/02 22:43:45, Dirk Pranke wrote:
>
https://codereview.chromium.org/2547963002/diff/1/build/config/compiler/compi...
> File build/config/compiler/compiler.gni (right):
> 
>
https://codereview.chromium.org/2547963002/diff/1/build/config/compiler/compi...
> build/config/compiler/compiler.gni:102: symbol_level = 1
> It looks like you're hitting the same limitation Android is (see the
> ignore_elf32_limitation block, below).
> 
> Can you merge the two together?

I like that idea. One small blocker exists; I would like to replace
"android_64bit_target_cpu" with a more general "is_target_cpu_64_bit". Where do
you suggest we declare this variable? No obvious .gni file jumps out at me at
the moment.

[bcf, 2016-12-05 19:23:20]

Description was changed from

==========
[Chromecast] Use symbol_level=1 for 32-bit GCC toolchains.

When using 32-bit GCC toolchains on non-component builds, generated
artifacts are too big for 32-bit address space with full symbols. Force
users to either reduce the symbol level or use the component build.

BUG=670776
==========

to

==========
[Chromecast] Use symbol_level=1 for 32-bit GCC toolchains.

When using 32-bit GCC toolchains on non-component builds, generated
artifacts are too big for 32-bit address space with full symbols. Force
users to either reduce the symbol level or use the component build.

BUG=670776
==========

[Dirk Pranke, 2016-12-06 02:29:09]

On 2016/12/05 17:58:40, slan wrote:
> I like that idea. One small blocker exists; I would like to replace
> "android_64bit_target_cpu" with a more general "is_target_cpu_64_bit". Where
do
> you suggest we declare this variable? No obvious .gni file jumps out at me at
> the moment.

I'd put it in //build/config/compiler/compiler.gni . That's not necessarily the
most obvious location,
but it's better than most candidates. The only other place it might belong would
be in BUILDCONFIG.gn,
but neither brettw nor I want to add things to that file.

[slan, 2016-12-06 06:40:28]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 06:40:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[slan, 2016-12-06 06:41:38]

slan@chromium.org changed reviewers:
+ agrieve@chromium.org

[slan, 2016-12-06 06:41:38]

Done. 
+Andrew for 64bit variable change, PTAL!

[commit-bot: I haz the power, 2016-12-06 08:07:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 08:07:44]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-12-06 14:57:44]

lgtm /w nit.

https://codereview.chromium.org/2547963002/diff/20001/build/config/android/co...
File build/config/android/config.gni (left):

https://codereview.chromium.org/2547963002/diff/20001/build/config/android/co...
build/config/android/config.gni:312: if (target_cpu == "arm64" || target_cpu ==
"x64" || target_cpu == "mips64el") {
nit: It would be better to leave android_64bit_target_cpu around until it's no
longer used downstream (e.g. add a TODO: remove once unused downstream, then
wait for a roll, then remove downstream usage, then delete todo)

I can take care of deleting downstream & the TODO if you're not set up for doing
this already.

[agrieve, 2016-12-06 14:58:05]

agrieve@chromium.org changed reviewers:
+ michaelbai@chromium.org

[slan, 2016-12-06 15:19:01]

Description was changed from

==========
[Chromecast] Use symbol_level=1 for 32-bit GCC toolchains.

When using 32-bit GCC toolchains on non-component builds, generated
artifacts are too big for 32-bit address space with full symbols. Force
users to either reduce the symbol level or use the component build.

BUG=670776
==========

to

==========
[Chromecast] Use symbol_level=1 for 32-bit GCC toolchains.

When using 32-bit GCC toolchains on non-component builds, generated
artifacts are too big for 32-bit address space with full symbols. Force
users to either reduce the symbol level or use the component build.

BUG=670776
BUG=671624
==========

[slan, 2016-12-06 15:19:39]

Andrew, thanks for volunteering to do clean-up. Restored the variable and took
out a bug for you.

https://codereview.chromium.org/2547963002/diff/20001/build/config/android/co...
File build/config/android/config.gni (left):

https://codereview.chromium.org/2547963002/diff/20001/build/config/android/co...
build/config/android/config.gni:312: if (target_cpu == "arm64" || target_cpu ==
"x64" || target_cpu == "mips64el") {
On 2016/12/06 14:57:44, agrieve wrote:
> nit: It would be better to leave android_64bit_target_cpu around until it's no
> longer used downstream (e.g. add a TODO: remove once unused downstream, then
> wait for a roll, then remove downstream usage, then delete todo)
> 
> I can take care of deleting downstream & the TODO if you're not set up for
doing
> this already.

Done.

[slan, 2016-12-06 15:21:22]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 15:21:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 16:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 16:06:13]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[slan, 2016-12-06 16:32:19]

Turns out I cannot directly reference is_target_cpu_64bit in //b/c/a/config.gni
without creating an import() loop in the .gni files... 

The code for the unused var will have to be slightly redundant until it is
pruned from the codebase.

[slan, 2016-12-06 16:32:38]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 16:33:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[slan, 2016-12-06 16:34:17]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 16:34:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mbjorge, 2016-12-06 17:26:17]

lgtm

[commit-bot: I haz the power, 2016-12-06 17:54:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 17:54:21]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-12-06 20:21:56]

lgtm

[slan, 2016-12-06 20:28:21]

The CQ bit was checked by slan@chromium.org

[slan, 2016-12-06 20:28:21]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2547963002/#ps80001
(title: "Fix comment typo")

[commit-bot: I haz the power, 2016-12-06 20:29:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 20:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 20:52:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)