Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: build/config/android/config.gni

Issue 2547963002: [Chromecast] Use symbol_level=1 for 32-bit GCC toolchains.
Patch Set: Fix comment typo Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/system_webview_apk_tmpl.gni ('k') | build/config/compiler/compiler.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/config.gni
diff --git a/build/config/android/config.gni b/build/config/android/config.gni
index d5948f2fbf373c0b89c3074d912d5b821ffaa450..d335c991664284df0090d8f99eff8ddf9dab7f10 100644
--- a/build/config/android/config.gni
+++ b/build/config/android/config.gni
@@ -309,6 +309,12 @@ if (is_android) {
}
# Secondary ABI -------------------------------------------------------------
+ # android_64bit_target_cpu has been deprecated and will soon be removed. Use
+ # is_target_cpu_64bit instead (see //build/config/compiler/compiler.gni).
+ # Note: This variable cannot take the value of is_target_cpu_64bit directly,
+ # as that would cause an import loop.
+ # TODO(agrieve): Remove this variable once it's no longer used downstream.
+ # https://crbug.com/671624
if (target_cpu == "arm64" || target_cpu == "x64" || target_cpu == "mips64el") {
android_64bit_target_cpu = true
} else if (target_cpu == "arm" || target_cpu == "x86" ||
« no previous file with comments | « android_webview/system_webview_apk_tmpl.gni ('k') | build/config/compiler/compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698