Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2015 The Chromium Authors. All rights reserved. | 1 # Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 import("//build/config/android/config.gni") | 5 import("//build/config/android/config.gni") |
| 6 import("//build/config/chrome_build.gni") | 6 import("//build/config/chrome_build.gni") |
| 7 import("//build/config/chromecast_build.gni") | 7 import("//build/config/chromecast_build.gni") |
| 8 import("//build/config/sanitizers/sanitizers.gni") | 8 import("//build/config/sanitizers/sanitizers.gni") |
| 9 import("//build/toolchain/goma.gni") | 9 import("//build/toolchain/goma.gni") |
| 10 import("//build/toolchain/toolchain.gni") | 10 import("//build/toolchain/toolchain.gni") |
| (...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 86 # Reduce symbol level when it will cause invalid elf files to be created | 86 # Reduce symbol level when it will cause invalid elf files to be created |
| 87 # (due to file size). https://crbug.com/648948. | 87 # (due to file size). https://crbug.com/648948. |
| 88 symbol_level = 1 | 88 symbol_level = 1 |
| 89 } else if (is_win && use_goma && !is_clang) { | 89 } else if (is_win && use_goma && !is_clang) { |
| 90 # goma doesn't support PDB files, so we disable symbols during goma | 90 # goma doesn't support PDB files, so we disable symbols during goma |
| 91 # compilation because otherwise the redundant debug information generated | 91 # compilation because otherwise the redundant debug information generated |
| 92 # by visual studio (repeated in every .obj file) makes linker | 92 # by visual studio (repeated in every .obj file) makes linker |
| 93 # memory consumption and link times unsustainable (crbug.com/630074). | 93 # memory consumption and link times unsustainable (crbug.com/630074). |
| 94 # Clang on windows does not have this issue. | 94 # Clang on windows does not have this issue. |
| 95 symbol_level = 1 | 95 symbol_level = 1 |
| 96 } else if (is_chromecast && !is_clang && !is_component_build && | |
| 97 target_cpu != "x64" && target_cpu != "arm64") { | |
| 98 # When using a 32-bit GCC toolchain for a non-component build, build | |
| 99 # artifacts exceed 4GB in size if full symbols are used. For this | |
| 100 # scenario, use symbol_level=1. More long term solutions are discussed here: | |
| 101 # https://crbug.com/670776. | |
| 102 symbol_level = 1 | |
|
Dirk Pranke
2016/12/02 22:43:45
It looks like you're hitting the same limitation A
| |
| 96 } else if (!is_linux || is_debug || is_official_build || is_chromecast) { | 103 } else if (!is_linux || is_debug || is_official_build || is_chromecast) { |
| 97 # Linux is slowed by having symbols as part of the target binary, whereas | 104 # Linux is slowed by having symbols as part of the target binary, whereas |
| 98 # Mac and Windows have them separate, so in Release Linux, default them off, | 105 # Mac and Windows have them separate, so in Release Linux, default them off, |
| 99 # but keep them on for Official builds and Chromecast builds. | 106 # but keep them on for Official builds and Chromecast builds. |
| 100 symbol_level = 2 | 107 symbol_level = 2 |
| 101 } else if (using_sanitizer) { | 108 } else if (using_sanitizer) { |
| 102 # Sanitizers require symbols for filename suppressions to work. | 109 # Sanitizers require symbols for filename suppressions to work. |
| 103 symbol_level = 1 | 110 symbol_level = 1 |
| 104 } else { | 111 } else { |
| 105 symbol_level = 0 | 112 symbol_level = 0 |
| 106 } | 113 } |
| 107 } | 114 } |
| 108 | 115 |
| 116 # Assert that the configuration isn't going to hit https://crbug.com/670776. | |
| 117 assert(!is_chromecast || is_clang || is_component_build || | |
| 118 target_cpu == "x64" || target_cpu == "arm64" || symbol_level < 2, | |
| 119 "Chromecast builds using a 32-bit GCC toolchain cannot use " + | |
| 120 "symbol_level=2 for a non-component build. Consider using a clang " + | |
| 121 "toolchain or setting is_component_build=true. See " + | |
| 122 "crbug.com/670776 for more details.") | |
| 123 | |
| 109 # Assert that the configuration isn't going to hit https://crbug.com/648948. | 124 # Assert that the configuration isn't going to hit https://crbug.com/648948. |
| 110 assert(ignore_elf32_limitations || !is_android || | 125 assert(ignore_elf32_limitations || !is_android || |
| 111 (android_64bit_target_cpu && !build_apk_secondary_abi) || | 126 (android_64bit_target_cpu && !build_apk_secondary_abi) || |
| 112 is_component_build || symbol_level < 2 || is_clang, | 127 is_component_build || symbol_level < 2 || is_clang, |
| 113 "Android 32-bit non-component, non-clang builds cannot have " + | 128 "Android 32-bit non-component, non-clang builds cannot have " + |
| 114 "symbol_level=2 due to 4GiB file size limit, see " + | 129 "symbol_level=2 due to 4GiB file size limit, see " + |
| 115 "https://crbug.com/648948. If you really want to try this out, " + | 130 "https://crbug.com/648948. If you really want to try this out, " + |
| 116 "set ignore_elf32_limitations=true.") | 131 "set ignore_elf32_limitations=true.") |
| OLD | NEW |