Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2547833004: Revert of Updating the CLD3 commit hash in DEPS (Closed)

Created:
4 years ago by ynovikov
Modified:
4 years ago
CC:
chromium-reviews, djweiss1, riesa
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Updating the CLD3 commit hash in DEPS (patchset #1 id:1 of https://codereview.chromium.org/2546943002/ ) Reason for revert: I believe this breaks https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29/builds/398 base::WeakPtr<base::win::ObjectWatcher>::get [0x1035E083+67] invalid_parameter [0x66D62011+161] std::_String_const_iterator<std::_String_val<std::_Simple_types<char> > >::operator* [0x023398F3+211] std::_String_iterator<std::_String_val<std::_Simple_types<char> > >::operator* [0x0233994F+15] chrome_lang_id::FMLParser::NextItem [0x06832F16+726] chrome_lang_id::FMLParser::Initialize [0x06832B1F+111] chrome_lang_id::FMLParser::Parse [0x068330CF+31] chrome_lang_id::GenericFeatureExtractor::Parse [0x06835340+48] ?Setup@?$EmbeddingFeatureExtractor@V?$FeatureExtractor@VSentence@chrome_lang_id@@$$V@chrome_lang_id@@VSentence@2@$$V@chrome_lang_id@@UAEXPAVTaskContext@2@@Z [0x0681AD70+128] chrome_lang_id::NNetLanguageIdentifier::Setup [0x0681AE8C+28] chrome_lang_id::NNetLanguageIdentifier::NNetLanguageIdentifier [0x06815F2F+527] chrome_lang_id::NNetLanguageIdentifier::NNetLanguageIdentifier [0x06816009+25] translate::DeterminePageLanguage [0x06A3F017+1287] translate::DeterminePageLanguage [0x06A3EC50+320] translate::TranslateHelper::PageCaptured [0x06A3D13F+335] ChromeRenderFrameObserver::CapturePageText [0x06874729+489] ChromeRenderFrameObserver::DidMeaningfulLayout [0x06874CA9+73] content::RenderFrameImpl::DidMeaningfulLayout [0x12BA7F73+99] content::RenderWidget::didMeaningfulLayout [0x12C5FC09+169] blink::WebViewImpl::updateAllLifecyclePhases [0x1A84A852+690] blink::WebViewImpl::resizeViewWhileAnchored [0x1A844719+265] blink::WebViewImpl::resizeWithBrowserControls [0x1A844A8E+670] content::RenderViewImpl::ResizeWebWidget [0x12C39199+89] content::RenderWidget::Resize [0x12C5AB34+756] content::RenderWidget::OnResize [0x12C595F2+114] content::RenderViewImpl::OnResize [0x12C37F54+516] base::DispatchToMethodImpl<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),std::tuple<content::ResizeParams> const &,0> [0x12C4B006+54] base::DispatchToMethod<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),std::tuple<content::ResizeParams> const &> [0x12C4A505+53] IPC::DispatchToMethod<content::RenderWidget,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),void,std::tuple<content::ResizeParams> > [0x12C4AAD6+38] IPC::MessageT<ViewMsg_Resize_Meta,std::tuple<content::ResizeParams>,void>::Dispatch<content::RenderWidget,content::RenderWidget,void,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &)> [0x12C47F5C+300] content::RenderWidget::OnMessageReceived [0x12C580F7+1975] content::RenderViewImpl::OnMessageReceived [0x12C36F81+6561] IPC::MessageRouter::RouteMessage [0x0D90088A+58] content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage [0x109E2FF6+22] IPC::MessageRouter::OnMessageReceived [0x0D9005DA+58] content::ChildThreadImpl::OnMessageReceived [0x109E228F+1439] IPC::ChannelProxy::Context::OnDispatchMessage [0x0D8AD953+115] base::internal::FunctorTraits<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),void>::Invoke<scoped_refptr<IPC::ChannelProxy::Context> const &,IPC::Message const &> [0x0D8A6995+37] base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall IPC::ChannelProxy::Context::*const &)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context> const &,IPC::Message const &> [0x0D8A7055+53] base::internal::Invoker<base::internal::BindState<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message>,void __cdecl(void)>::RunImpl<void (__thiscall IPC::ChannelProxy::Context::*cons [0x0D8A7453+83] base::internal::Invoker<base::internal::BindState<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message>,void __cdecl(void)>::Run [0x0D8AE364+36] base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x1008A944+68] base::debug::TaskAnnotator::RunTask [0x1008AADF+367] blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue [0x191CE676+1094] blink::scheduler::TaskQueueManager::DoWork [0x191CCDA1+737] base::internal::FunctorTraits<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),void>::Invoke<base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &> [0x191C28ED+61] base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall blink::scheduler::TaskQueueManager::*const &)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &> [0x191C2A43+83] base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::RunImpl<void (__thiscall blink::sc [0x191C2B32+114] base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::Run [0x191CEFC4+36] base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x1008A944+68] base::debug::TaskAnnotator::RunTask [0x1008AADF+367] base::MessageLoop::RunTask [0x10105444+660] base::MessageLoop::DeferOrRunPendingTask [0x1010323C+44] base::MessageLoop::DoWork [0x10103822+242] base::MessagePumpDefault::Run [0x1010B4FE+190] base::MessageLoop::RunHandler [0x1010513C+444] base::RunLoop::Run [0x101B7594+52] content::RendererMain [0x12C789FE+830] content::RunNamedProcessTypeMain [0x130B0007+135] content::ContentMainRunnerImpl::Run [0x130AFEC8+488] content::ContentMain [0x130ADDE4+100] ChromeMain [0x02315ED8+264] Original issue's description: > Updating the CLD3 commit hash in DEPS > > The main change are: > - a retrained model with additional script-based features > - replacing "vector" with "std::vector" > > Link to the page in GitHub showing the diff: > https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a > > BUG=670742 > > Committed: https://crrev.com/f31c5cafc3b085a1f08ed917e518dcc1b30e175f > Cr-Commit-Position: refs/heads/master@{#436034} TBR=groby@chromium.org,rouslan@chromium.org,abakalov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=670742 Committed: https://crrev.com/8377083c34ac86e133e527bacc2ae49a0ead53b5 Cr-Commit-Position: refs/heads/master@{#436196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
ynovikov
Created Revert of Updating the CLD3 commit hash in DEPS
4 years ago (2016-12-03 04:50:01 UTC) #1
ynovikov
On 2016/12/03 04:50:01, ynovikov wrote: > Created Revert of Updating the CLD3 commit hash in ...
4 years ago (2016-12-03 04:51:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547833004/1
4 years ago (2016-12-03 05:07:19 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-03 05:07:20 UTC) #6
ynovikov
Ken, could you lgtm this, please?
4 years ago (2016-12-04 01:02:16 UTC) #8
please use gerrit instead
To better understand reasoning for this revert, please point me to the location of the ...
4 years ago (2016-12-04 01:09:59 UTC) #9
ynovikov
On 2016/12/04 01:09:59, rouslan wrote: > To better understand reasoning for this revert, please point ...
4 years ago (2016-12-04 01:18:22 UTC) #10
Ken Russell (switch to Gerrit)
LGTM. Thanks Yuly for tracking this down.
4 years ago (2016-12-04 16:52:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547833004/1
4 years ago (2016-12-04 16:52:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-04 16:53:19 UTC) #16
Ken Russell (switch to Gerrit)
On 2016/12/04 01:18:22, ynovikov wrote: > On 2016/12/04 01:09:59, rouslan wrote: > > To better ...
4 years ago (2016-12-04 16:54:11 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-04 16:55:31 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8377083c34ac86e133e527bacc2ae49a0ead53b5
Cr-Commit-Position: refs/heads/master@{#436196}

Powered by Google App Engine
This is Rietveld 408576698