|
|
Created:
4 years ago by Anton Bakalov Modified:
4 years ago CC:
chromium-reviews, djweiss1, riesa Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdating the CLD3 commit hash in DEPS
The main change are:
- a retrained model with additional script-based features
- replacing "vector" with "std::vector"
Link to the page in GitHub showing the diff:
https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a
BUG=670742
Committed: https://crrev.com/f31c5cafc3b085a1f08ed917e518dcc1b30e175f
Cr-Commit-Position: refs/heads/master@{#436034}
Patch Set 1 #Messages
Total messages: 21 (11 generated)
The CQ bit was checked by abakalov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
abakalov@chromium.org changed reviewers: + groby@chromium.org, rouslan@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Please specify the bug number and add the link to the change list in the description.
Description was changed from ========== Updating the CLD3 commit hash in DEPS The main change is a retrained model with additional script-based features. BUG= ========== to ========== Updating the CLD3 commit hash in DEPS The main change is a retrained model with additional script-based features. BUG=670742 ==========
On 2016/12/02 14:22:30, rouslan wrote: > Please specify the bug number and add the link to the change list in the > description. It was on my todo list :) Done.
On 2016/12/02 14:22:30, rouslan wrote: > link to the change list in the description. Sorry for confusion. I'm interested in seeing the changes in cld_3 repository from 79f017acfa55012ab8a553700e4b7fe78ba3709c to fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a. Can you link to the description of those changes in github? That's useful for anyone investigating regressions in language detection, for example.
Description was changed from ========== Updating the CLD3 commit hash in DEPS The main change is a retrained model with additional script-based features. BUG=670742 ========== to ========== Updating the CLD3 commit hash in DEPS The main change are: - a retrained model with additional script-based features - replacing "vector" with "std::vector" Link to the page in GitHub showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a BUG=670742 ==========
On 2016/12/02 17:24:14, rouslan wrote: > On 2016/12/02 14:22:30, rouslan wrote: > > link to the change list in the description. > > Sorry for confusion. I'm interested in seeing the changes in cld_3 repository > from 79f017acfa55012ab8a553700e4b7fe78ba3709c to > fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a. Can you link to the description of > those changes in github? That's useful for anyone investigating regressions in > language detection, for example. Good point. Done.
The CQ bit was checked by rouslan@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1480709472734850, "parent_rev": "446cb0575f807e40451262613d749d1314242d4d", "commit_rev": "52c5494be0eff4d28037dd791498ddc7a081b82f"}
Message was sent while issue was closed.
Description was changed from ========== Updating the CLD3 commit hash in DEPS The main change are: - a retrained model with additional script-based features - replacing "vector" with "std::vector" Link to the page in GitHub showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a BUG=670742 ========== to ========== Updating the CLD3 commit hash in DEPS The main change are: - a retrained model with additional script-based features - replacing "vector" with "std::vector" Link to the page in GitHub showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a BUG=670742 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Updating the CLD3 commit hash in DEPS The main change are: - a retrained model with additional script-based features - replacing "vector" with "std::vector" Link to the page in GitHub showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a BUG=670742 ========== to ========== Updating the CLD3 commit hash in DEPS The main change are: - a retrained model with additional script-based features - replacing "vector" with "std::vector" Link to the page in GitHub showing the diff: https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a BUG=670742 Committed: https://crrev.com/f31c5cafc3b085a1f08ed917e518dcc1b30e175f Cr-Commit-Position: refs/heads/master@{#436034} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f31c5cafc3b085a1f08ed917e518dcc1b30e175f Cr-Commit-Position: refs/heads/master@{#436034}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2547833004/ by ynovikov@chromium.org. The reason for reverting is: I believe this breaks https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%... base::WeakPtr<base::win::ObjectWatcher>::get [0x1035E083+67] invalid_parameter [0x66D62011+161] std::_String_const_iterator<std::_String_val<std::_Simple_types<char> > >::operator* [0x023398F3+211] std::_String_iterator<std::_String_val<std::_Simple_types<char> > >::operator* [0x0233994F+15] chrome_lang_id::FMLParser::NextItem [0x06832F16+726] chrome_lang_id::FMLParser::Initialize [0x06832B1F+111] chrome_lang_id::FMLParser::Parse [0x068330CF+31] chrome_lang_id::GenericFeatureExtractor::Parse [0x06835340+48] ?Setup@?$EmbeddingFeatureExtractor@V?$FeatureExtractor@VSentence@chrome_lang_id@@$$V@chrome_lang_id@@VSentence@2@$$V@chrome_lang_id@@UAEXPAVTaskContext@2@@Z [0x0681AD70+128] chrome_lang_id::NNetLanguageIdentifier::Setup [0x0681AE8C+28] chrome_lang_id::NNetLanguageIdentifier::NNetLanguageIdentifier [0x06815F2F+527] chrome_lang_id::NNetLanguageIdentifier::NNetLanguageIdentifier [0x06816009+25] translate::DeterminePageLanguage [0x06A3F017+1287] translate::DeterminePageLanguage [0x06A3EC50+320] translate::TranslateHelper::PageCaptured [0x06A3D13F+335] ChromeRenderFrameObserver::CapturePageText [0x06874729+489] ChromeRenderFrameObserver::DidMeaningfulLayout [0x06874CA9+73] content::RenderFrameImpl::DidMeaningfulLayout [0x12BA7F73+99] content::RenderWidget::didMeaningfulLayout [0x12C5FC09+169] blink::WebViewImpl::updateAllLifecyclePhases [0x1A84A852+690] blink::WebViewImpl::resizeViewWhileAnchored [0x1A844719+265] blink::WebViewImpl::resizeWithBrowserControls [0x1A844A8E+670] content::RenderViewImpl::ResizeWebWidget [0x12C39199+89] content::RenderWidget::Resize [0x12C5AB34+756] content::RenderWidget::OnResize [0x12C595F2+114] content::RenderViewImpl::OnResize [0x12C37F54+516] base::DispatchToMethodImpl<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),std::tuple<content::ResizeParams> const &,0> [0x12C4B006+54] base::DispatchToMethod<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),std::tuple<content::ResizeParams> const &> [0x12C4A505+53] IPC::DispatchToMethod<content::RenderWidget,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),void,std::tuple<content::ResizeParams> > [0x12C4AAD6+38] IPC::MessageT<ViewMsg_Resize_Meta,std::tuple<content::ResizeParams>,void>::Dispatch<content::RenderWidget,content::RenderWidget,void,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &)> [0x12C47F5C+300] content::RenderWidget::OnMessageReceived [0x12C580F7+1975] content::RenderViewImpl::OnMessageReceived [0x12C36F81+6561] IPC::MessageRouter::RouteMessage [0x0D90088A+58] content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage [0x109E2FF6+22] IPC::MessageRouter::OnMessageReceived [0x0D9005DA+58] content::ChildThreadImpl::OnMessageReceived [0x109E228F+1439] IPC::ChannelProxy::Context::OnDispatchMessage [0x0D8AD953+115] base::internal::FunctorTraits<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),void>::Invoke<scoped_refptr<IPC::ChannelProxy::Context> const &,IPC::Message const &> [0x0D8A6995+37] base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall IPC::ChannelProxy::Context::*const &)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context> const &,IPC::Message const &> [0x0D8A7055+53] base::internal::Invoker<base::internal::BindState<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message>,void __cdecl(void)>::RunImpl<void (__thiscall IPC::ChannelProxy::Context::*cons [0x0D8A7453+83] base::internal::Invoker<base::internal::BindState<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message>,void __cdecl(void)>::Run [0x0D8AE364+36] base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x1008A944+68] base::debug::TaskAnnotator::RunTask [0x1008AADF+367] blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue [0x191CE676+1094] blink::scheduler::TaskQueueManager::DoWork [0x191CCDA1+737] base::internal::FunctorTraits<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),void>::Invoke<base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &> [0x191C28ED+61] base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall blink::scheduler::TaskQueueManager::*const &)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &> [0x191C2A43+83] base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::RunImpl<void (__thiscall blink::sc [0x191C2B32+114] base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::Run [0x191CEFC4+36] base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x1008A944+68] base::debug::TaskAnnotator::RunTask [0x1008AADF+367] base::MessageLoop::RunTask [0x10105444+660] base::MessageLoop::DeferOrRunPendingTask [0x1010323C+44] base::MessageLoop::DoWork [0x10103822+242] base::MessagePumpDefault::Run [0x1010B4FE+190] base::MessageLoop::RunHandler [0x1010513C+444] base::RunLoop::Run [0x101B7594+52] content::RendererMain [0x12C789FE+830] content::RunNamedProcessTypeMain [0x130B0007+135] content::ContentMainRunnerImpl::Run [0x130AFEC8+488] content::ContentMain [0x130ADDE4+100] ChromeMain [0x02315ED8+264]. |