[Media Router] Handle multiple Presentation URLs when creating routes

[Media Router] Handle multiple Presentation URLs when creating routes

Based on https://codereview.chromium.org/2488403002/

- Implement CanConnectToMediaSource() in media_source_helper.cc
- In PresentationServiceDelegateImpl::JoinSession, pick cast specific url and send it to cast MRP

BUG=627655
Committed: https://crrev.com/81cb26bf6bad31e3f5858c43d828e689d3b789f4
Cr-Commit-Position: refs/heads/master@{#437035}

[zhaobin, 2016-12-01 23:25:01]

zhaobin@chromium.org changed reviewers:
+ imcheng@chromium.org, mfoltz@chromium.org

[mark a. foltz, 2016-12-02 20:59:07]

mfoltz@chromium.org changed reviewers:
+ takumif@chromium.org

[mark a. foltz, 2016-12-02 20:59:09]

+takumif as they wrote the code that handles multiple URLs in MediaRouterUI

Looks great.  Looking forward to landing the Blink patch and getting this
working end to end, finally!

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_router_dialog_controller_unittest.cc
(right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_dialog_controller_unittest.cc:70:
return std::unique_ptr<CreatePresentationConnectionRequest>(
I think base::MakeUnique is preferred for constructing new objects held as
unique_ptr.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_dialog_controller_unittest.cc:72:
RenderFrameHostId(1, 2), {GURL("http://example.com")},
Can you pass multiple URLs here?

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_source_helper.cc (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_source_helper.cc:25: constexpr char
kCastPresentationUrlFormat[] =
s/Format/Prefix/

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_source_helper.h (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_source_helper.h:32: // Returns true if
|source| is a media route type that can be connected to the
Nit: s/media route type/media source/

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/presentation_service_delegate_impl.cc (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:781:
error_cb.Run(content::PresentationError(content::PRESENTATION_ERROR_UNKNOWN,
A couple of things:

- Ideally the validation in the PresentationRequest constructor in Blink should
match up as closely as we can with any re-validation we do on the browser side,
so the developer can't construct a PresentationRequest that is guaranteed to
fail.

- It would be better to define a specific content:: error code for this case so
we can reject the Promise to start() with a NotFoundError; that seems like the
best thing to do.

I think it would be better to make any changes separately.  Filed
crbug.com/670848, can you add a TODO() here?

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:782: "Invalid
presentation arguments."));
Nit: "Invalid presentation URL."

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:820: //
TODO(zhaobin): This may break if we have multiple cast specific urls.
Can you elaborate on this?  I would say:

To fix this, we need the Media Router to keep track of which presentation URL
was used to start the presentation named by |presentation_id|.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:828:
"Presentation urls do support reconnect."));
This should probably be content::PRESENTATION_ERROR_NO_PRESENTATION_FOUND

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/route_request_result.cc (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/route_request_result.cc:37: presentation_url_ =
route_ ? GURL(route_->media_source().id()) : GURL("");
There is a TODO to have MediaSource contain a GURL if it was created from a URL.
 That would make this cleaner, but not necessary to fix in this patch.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
File
chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
(right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc:258:
RenderFrameHostId(1, 2), {GURL("http://test.com")},
Can you pass multiple URLs here?

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_ui.cc (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_ui.cc:96: [](const
MediaSource& source) {
Is the lambda function necessary, or can you pass CanConnectToMediaSource
directly?

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc:490:
RenderFrameHostId(0, 0), {GURL("http://google.com/presentation")},
It would be good to update test cases to take multiple URLs just to exercise any
code that depends on looping over mulitple URLs.

[zhaobin, 2016-12-02 22:50:57]

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_router_dialog_controller_unittest.cc
(right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_dialog_controller_unittest.cc:70:
return std::unique_ptr<CreatePresentationConnectionRequest>(
On 2016/12/02 20:59:08, mark a. foltz wrote:
> I think base::MakeUnique is preferred for constructing new objects held as
> unique_ptr.

Get compile error with base::MakeUnique. It seems that template is not working
correctly when we use std::vector as constructor parameter.

../../base/memory/ptr_util.h:69:49: note: candidate template ignored:
substitution failure [with T =
media_router::CreatePresentationConnectionRequest]: no type named 'Invalid' in
'base::internal::MakeUniqueResult<media_router::CreatePresentationConnectionRequest>'
typename internal::MakeUniqueResult<T>::Invalid MakeUnique(Args&&... args) =

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_dialog_controller_unittest.cc:72:
RenderFrameHostId(1, 2), {GURL("http://example.com")},
On 2016/12/02 20:59:08, mark a. foltz wrote:
> Can you pass multiple URLs here?

Done.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_source_helper.cc (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_source_helper.cc:25: constexpr char
kCastPresentationUrlFormat[] =
On 2016/12/02 20:59:08, mark a. foltz wrote:
> s/Format/Prefix/

Done.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_source_helper.h (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_source_helper.h:32: // Returns true if
|source| is a media route type that can be connected to the
On 2016/12/02 20:59:08, mark a. foltz wrote:
> Nit: s/media route type/media source/

Done.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/presentation_service_delegate_impl.cc (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:781:
error_cb.Run(content::PresentationError(content::PRESENTATION_ERROR_UNKNOWN,
On 2016/12/02 20:59:08, mark a. foltz wrote:
> A couple of things:
> 
> - Ideally the validation in the PresentationRequest constructor in Blink
should
> match up as closely as we can with any re-validation we do on the browser
side,
> so the developer can't construct a PresentationRequest that is guaranteed to
> fail.
> 
> - It would be better to define a specific content:: error code for this case
so
> we can reject the Promise to start() with a NotFoundError; that seems like the
> best thing to do.
> 
> I think it would be better to make any changes separately.  Filed
> crbug.com/670848, can you add a TODO() here?
> 

Done.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:782: "Invalid
presentation arguments."));
On 2016/12/02 20:59:08, mark a. foltz wrote:
> Nit: "Invalid presentation URL."

Done.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:820: //
TODO(zhaobin): This may break if we have multiple cast specific urls.
On 2016/12/02 20:59:09, mark a. foltz wrote:
> Can you elaborate on this?  I would say:
> 
> To fix this, we need the Media Router to keep track of which presentation URL
> was used to start the presentation named by |presentation_id|.

Done.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:828:
"Presentation urls do support reconnect."));
On 2016/12/02 20:59:09, mark a. foltz wrote:
> This should probably be content::PRESENTATION_ERROR_NO_PRESENTATION_FOUND

Done.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/route_request_result.cc (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/route_request_result.cc:37: presentation_url_ =
route_ ? GURL(route_->media_source().id()) : GURL("");
On 2016/12/02 20:59:09, mark a. foltz wrote:
> There is a TODO to have MediaSource contain a GURL if it was created from a
URL.
>  That would make this cleaner, but not necessary to fix in this patch.

Done.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
File
chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
(right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc:258:
RenderFrameHostId(1, 2), {GURL("http://test.com")},
On 2016/12/02 20:59:09, mark a. foltz wrote:
> Can you pass multiple URLs here?

Done.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_ui.cc (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_ui.cc:96: [](const
MediaSource& source) {
On 2016/12/02 20:59:09, mark a. foltz wrote:
> Is the lambda function necessary, or can you pass CanConnectToMediaSource
> directly?

Done.

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc (right):

https://codereview.chromium.org/2547703002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc:490:
RenderFrameHostId(0, 0), {GURL("http://google.com/presentation")},
On 2016/12/02 20:59:09, mark a. foltz wrote:
> It would be good to update test cases to take multiple URLs just to exercise
any
> code that depends on looping over mulitple URLs.

Done.

[mark a. foltz, 2016-12-02 23:13:37]

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/presentation_service_delegate_impl.cc (right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:825: // was
used to start the presentation named by |presentation_id|.
This line is doubled.

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:826: auto
presentation_url = std::find_if(
Note, we already have |presentation_id_to_route_id_| in PresentationFrame.   It
seems like we could move that into the MediaRouter itself and make it accessible
from this logic (or just have joinRoute() take a presentation id).

This may require changes to Cast, though, as they use more than one route per
presentation.  Hmmm.

[imcheng, 2016-12-05 21:58:39]

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/presentation_service_delegate_impl.cc (right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:933:
base::STLCount(presentation_request.presentation_urls(),
!base::ContainsValue(...)

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/ui/webui...
File
chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
(right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc:4:
#include <vector>
nit: add empty line before #include.

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_ui.cc (right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_ui.cc:339: // observer API for
this case.
+1, A specific API to query routes joinable with a given source would help.

[mark a. foltz, 2016-12-05 22:21:13]

lgtm with comments addressed.  Thanks!

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
File
chrome/browser/media/router/create_presentation_connection_request_unittest.cc
(right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/create_presentation_connection_request_unittest.cc:15:
const char kPresentationUrl1[] = "http://www.example.com/presentation.html";
Nit: Can you convert these to use constexpr while you are here?

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/media_source.h (right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/media_source.h:51: GURL url_;
Thanks :)

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/media_source_helper.cc (right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/media_source_helper.cc:65: return
base::StartsWith(source.id(), kCastPresentationUrlPrefix,
Can you compare host, port, scheme, and path prefix for source.url()?

[zhaobin, 2016-12-06 20:06:37]

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
File
chrome/browser/media/router/create_presentation_connection_request_unittest.cc
(right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/create_presentation_connection_request_unittest.cc:15:
const char kPresentationUrl1[] = "http://www.example.com/presentation.html";
On 2016/12/05 22:21:13, mark a. foltz wrote:
> Nit: Can you convert these to use constexpr while you are here?

Done.

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/media_source_helper.cc (right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/media_source_helper.cc:65: return
base::StartsWith(source.id(), kCastPresentationUrlPrefix,
On 2016/12/05 22:21:13, mark a. foltz wrote:
> Can you compare host, port, scheme, and path prefix for source.url()?

Done.

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/presentation_service_delegate_impl.cc (right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:825: // was
used to start the presentation named by |presentation_id|.
On 2016/12/02 23:13:37, mark a. foltz wrote:
> This line is doubled.

Done.

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:826: auto
presentation_url = std::find_if(
On 2016/12/02 23:13:37, mark a. foltz wrote:
> Note, we already have |presentation_id_to_route_id_| in PresentationFrame.  
It
> seems like we could move that into the MediaRouter itself and make it
accessible
> from this logic (or just have joinRoute() take a presentation id).
> 
> This may require changes to Cast, though, as they use more than one route per
> presentation.  Hmmm.
> 

Acknowledged.

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/presentation_service_delegate_impl.cc:933:
base::STLCount(presentation_request.presentation_urls(),
On 2016/12/05 21:58:39, imcheng wrote:
> !base::ContainsValue(...)

Done.

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/ui/webui...
File
chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
(right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc:4:
#include <vector>
On 2016/12/05 21:58:39, imcheng wrote:
> nit: add empty line before #include.

Done.

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/media_router/media_router_ui.cc (right):

https://codereview.chromium.org/2547703002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/media_router/media_router_ui.cc:339: // observer API for
this case.
On 2016/12/05 21:58:39, imcheng wrote:
> +1, A specific API to query routes joinable with a given source would help.

Acknowledged.

[imcheng, 2016-12-06 20:42:36]

lgtm

[takumif, 2016-12-06 21:00:07]

lgtm

https://codereview.chromium.org/2547703002/diff/60001/chrome/browser/media/ro...
File chrome/browser/media/router/media_source_helper.cc (right):

https://codereview.chromium.org/2547703002/diff/60001/chrome/browser/media/ro...
chrome/browser/media/router/media_source_helper.cc:71: return true;
Nit: Isn't this equivalent to

return source.url().SchemeIs(url::kHttpsScheme) &&
       source.url().DomainIs(kCastPresentationUrlDomain) &&
       source.url().has_path() &&
       source.url().path() == kCastPresentationUrlPath

[zhaobin, 2016-12-06 21:19:54]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 21:20:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 21:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 21:24:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[zhaobin, 2016-12-06 22:10:53]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 22:11:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:45:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:45:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[zhaobin, 2016-12-07 01:52:51]

Reverting back to use presentation_urls[0] in PSDImpl::JoinSession(). 

Patch fails android integration test and mr integration test, because we check
for cast specific url (android test uses wrong url, should be
"https://google.com/....."; mr integration test does not use cast specific url).

Finding cast specific url is not the correct way of implementing joinSession().
It is a similar workaround as presentation_urls[0]. The tests seem correct - we
should support arbitrary url. So we decide to leave the tests as it is and use
first url in PSDImpl::JoinSession().

[mark a. foltz, 2016-12-07 02:15:42]

OK.  I don't think this should block landing the final Blink change, since Cast
can control the order of the URLs set by the SDK to make it work as intended. 
But we should fix reconnect()/joinSession() as part of finishing support for
1-UA mode.

[zhaobin, 2016-12-07 02:28:23]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 02:28:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 03:39:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 03:39:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mark a. foltz, 2016-12-07 04:04:55]

Still lgtm

[zhaobin, 2016-12-07 18:40:51]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 18:41:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 19:31:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 19:31:06]

Dry run: This issue passed the CQ dry run.

[zhaobin, 2016-12-07 19:31:33]

The CQ bit was checked by zhaobin@chromium.org

[zhaobin, 2016-12-07 19:31:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
imcheng@chromium.org, takumif@chromium.org, mfoltz@chromium.org
Link to the patchset: https://codereview.chromium.org/2547703002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-07 19:32:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 19:42:58]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481139093911930,
"parent_rev": "397dbbb5ba840eac17496efbed573974f8352ba8", "commit_rev":
"c879dd4e606da8e4d8dbf59c8a9822a40d379414"}

[commit-bot: I haz the power, 2016-12-07 19:43:27]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-07 19:45:19]

Description was changed from

==========
[Media Router] Handle multiple Presentation URLs when creating routes

Based on https://codereview.chromium.org/2488403002/

- Implement CanConnectToMediaSource() in media_source_helper.cc
- In PresentationServiceDelegateImpl::JoinSession, pick cast specific url and
send it to cast MRP

BUG=627655
==========

to

==========
[Media Router] Handle multiple Presentation URLs when creating routes

Based on https://codereview.chromium.org/2488403002/

- Implement CanConnectToMediaSource() in media_source_helper.cc
- In PresentationServiceDelegateImpl::JoinSession, pick cast specific url and
send it to cast MRP

BUG=627655

Committed: https://crrev.com/81cb26bf6bad31e3f5858c43d828e689d3b789f4
Cr-Commit-Position: refs/heads/master@{#437035}
==========

[commit-bot: I haz the power, 2016-12-07 19:45:20]

Patchset 7 (id:??) landed as
https://crrev.com/81cb26bf6bad31e3f5858c43d828e689d3b789f4
Cr-Commit-Position: refs/heads/master@{#437035}