chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc - Issue 2547703002: [Media Router] Handle multiple Presentation URLs when creating routes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

Issue 2547703002: [Media Router] Handle multiple Presentation URLs when creating routes (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/presentation_service_delegate_impl.cc ('k') | chrome/browser/media/router/route_request_result.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

diff --git a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

index 55c550ee91f0fd0fa91bdc19a4a3af9ddfe0f85d..2de3a32f2cffac2ca4703ebb9cc78c70bdf5837a 100644

--- a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

+++ b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

@@ -31,6 +31,8 @@ namespace {

const char kPresentationUrl1[] = "http://foo.fakeurl.com/";

const char kPresentationUrl2[] = "http://bar.fakeurl.com/";

+const char kPresentationUrl3[] =

+ "https://google.com/cast#__castAppId__=233637DE";

const char kFrameUrl[] = "http://anotherframeurl.fakeurl.com/";

} // namespace

@@ -284,7 +286,7 @@ TEST_F(PresentationServiceDelegateImplTest, SetDefaultPresentationUrl) {

ASSERT_TRUE(delegate_impl_->HasDefaultPresentationRequest());

PresentationRequest request1 =

delegate_impl_->GetDefaultPresentationRequest();

- EXPECT_EQ(presentation_url1_, request1.presentation_url());

+ EXPECT_EQ(presentation_url1_, request1.presentation_urls()[0]);

EXPECT_EQ(RenderFrameHostId(render_process_id, routing_id),

request1.render_frame_host_id());

EXPECT_EQ(frame_url, request1.frame_url());

@@ -296,7 +298,7 @@ TEST_F(PresentationServiceDelegateImplTest, SetDefaultPresentationUrl) {

ASSERT_TRUE(delegate_impl_->HasDefaultPresentationRequest());

PresentationRequest request2 =

delegate_impl_->GetDefaultPresentationRequest();

- EXPECT_EQ(presentation_url2_, request2.presentation_url());

+ EXPECT_EQ(presentation_url2_, request2.presentation_urls()[0]);

EXPECT_EQ(RenderFrameHostId(render_process_id, routing_id),

request2.render_frame_host_id());

EXPECT_EQ(frame_url, request2.frame_url());

@@ -385,6 +387,7 @@ TEST_F(PresentationServiceDelegateImplTest, ListenForConnnectionStateChange) {

.WillOnce(SaveArg<4>(&route_response_callbacks));

const std::string kPresentationId("pid");

+ presentation_urls_.push_back(GURL(kPresentationUrl3));

MockCreatePresentationConnnectionCallbacks mock_create_connection_callbacks;

delegate_impl_->JoinSession(

render_process_id, routing_id, presentation_urls_, kPresentationId,