[Media Router] Handle multiple Presentation URLs when creating routes

chrome/browser/media/router/create_presentation_connection_request_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "chrome/browser/media/router/create_presentation_connection_request.h"
 #include "chrome/browser/media/router/media_source_helper.h"
 #include "content/public/browser/presentation_service_delegate.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace media_router {
 
 namespace {
 
-const char kPresentationUrl[] = "http://foo.com";
+const char kPresentationUrl1[] = "http://www.example.com/presentation.html";

[mark a. foltz, 2016/12/05 22:21:13]

Nit: Can you convert these to use constexpr while you are here?

[zhaobin, 2016/12/06 20:06:36]

Done.

+const char kPresentationUrl2[] = "http://www.example.net/alternate.html";
 const char kFrameUrl[] = "http://google.com";
 const char kPresentationId[] = "presentationId";
 const char kRouteId[] =
-    "urn:x-org.chromium:media:route:presentationId/cast-sink1/http://foo.com";
+    "urn:x-org.chromium:media:route:presentationId/cast-sink1/"
+    "http://www.example.com/presentation.html";
 
 }  // namespace
 
 class CreatePresentationConnectionRequestTest : public ::testing::Test {
  public:
   CreatePresentationConnectionRequestTest()
       : cb_invoked_(false),
         render_frame_host_id_(1, 2),
-        presentation_url_(kPresentationUrl),
-        presentation_urls_({presentation_url_}) {}
+        presentation_url_(kPresentationUrl1),
+        presentation_urls_({presentation_url_, GURL(kPresentationUrl2)}) {}
 
   ~CreatePresentationConnectionRequestTest() override {}
 
   void OnSuccess(const content::PresentationSessionInfo& expected_info,
                  const content::PresentationSessionInfo& actual_info,
                  const MediaRoute& route) {
     cb_invoked_ = true;
     EXPECT_EQ(expected_info.presentation_url, actual_info.presentation_url);
     EXPECT_EQ(expected_info.presentation_id, actual_info.presentation_id);
+    EXPECT_EQ(route.media_route_id(), kRouteId);
   }
 
   void OnError(const content::PresentationError& expected_error,
                const content::PresentationError& actual_error) {
     cb_invoked_ = true;
     EXPECT_EQ(expected_error.error_type, actual_error.error_type);
     EXPECT_EQ(expected_error.message, actual_error.message);
   }
 
   void FailOnSuccess(const content::PresentationSessionInfo& info,
                      const MediaRoute& route) {
     FAIL() << "Success callback should not have been called.";
   }
 
   void FailOnError(const content::PresentationError& error) {
     FAIL() << "Error should not have been called.";
   }
 
   bool cb_invoked_;
   const RenderFrameHostId render_frame_host_id_;
   GURL presentation_url_;
   std::vector<GURL> presentation_urls_;
 };
 
 // Test that the object's getters match the constructor parameters.
 TEST_F(CreatePresentationConnectionRequestTest, Getters) {
   content::PresentationError error(content::PRESENTATION_ERROR_UNKNOWN,
                                    "Unknown error.");
   CreatePresentationConnectionRequest request(
-      render_frame_host_id_, presentation_url_, GURL(kFrameUrl),
+      render_frame_host_id_, presentation_urls_, GURL(kFrameUrl),
       base::Bind(&CreatePresentationConnectionRequestTest::FailOnSuccess,
                  base::Unretained(this)),
       base::Bind(&CreatePresentationConnectionRequestTest::OnError,
                  base::Unretained(this), error));
 
   PresentationRequest presentation_request(render_frame_host_id_,
                                            presentation_urls_, GURL(kFrameUrl));
   EXPECT_TRUE(request.presentation_request().Equals(presentation_request));
   // Since we didn't explicitly call Invoke*, the error callback will be
   // invoked when |request| is destroyed.
 }
 
 TEST_F(CreatePresentationConnectionRequestTest, SuccessCallback) {
   content::PresentationSessionInfo session_info(presentation_url_,
                                                 kPresentationId);
   CreatePresentationConnectionRequest request(
-      render_frame_host_id_, presentation_url_, GURL(kFrameUrl),
+      render_frame_host_id_, {presentation_url_}, GURL(kFrameUrl),
       base::Bind(&CreatePresentationConnectionRequestTest::OnSuccess,
                  base::Unretained(this), session_info),
       base::Bind(&CreatePresentationConnectionRequestTest::FailOnError,
                  base::Unretained(this)));
   MediaRoute route(kRouteId, MediaSourceForTab(1), "sinkId", "Description",
                    false, "", false);
-  request.InvokeSuccessCallback(kPresentationId, route);
+  request.InvokeSuccessCallback(kPresentationId, presentation_url_, route);
   EXPECT_TRUE(cb_invoked_);
 }
 
 TEST_F(CreatePresentationConnectionRequestTest, ErrorCallback) {
   content::PresentationError error(
       content::PRESENTATION_ERROR_SESSION_REQUEST_CANCELLED,
       "This is an error message");
   CreatePresentationConnectionRequest request(
-      render_frame_host_id_, presentation_url_, GURL(kFrameUrl),
+      render_frame_host_id_, presentation_urls_, GURL(kFrameUrl),
       base::Bind(&CreatePresentationConnectionRequestTest::FailOnSuccess,
                  base::Unretained(this)),
       base::Bind(&CreatePresentationConnectionRequestTest::OnError,
                  base::Unretained(this), error));
   request.InvokeErrorCallback(error);
   EXPECT_TRUE(cb_invoked_);
 }
 
 }  // namespace media_router