Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: net/http/http_stream_factory_impl_job_controller.cc

Issue 2546533003: Respect QuicAllowed policy for new streams (Closed)
Patch Set: Fixed accesses to iothread globals from UI thread Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_job_controller.cc
diff --git a/net/http/http_stream_factory_impl_job_controller.cc b/net/http/http_stream_factory_impl_job_controller.cc
index 4e3aa673f3e74cfd75524af4417350c9712096e2..fa832db60546e43e6964876911a784ce4327086b 100644
--- a/net/http/http_stream_factory_impl_job_controller.cc
+++ b/net/http/http_stream_factory_impl_job_controller.cc
@@ -937,7 +937,7 @@ HttpStreamFactoryImpl::JobController::GetAlternativeServiceForInternal(
}
quic_all_broken = false;
- if (!session_->params().enable_quic)
+ if (!session_->params().is_enable_quic_for_new_streams())
Bence 2016/12/02 18:53:26 I believe this should be gated on both: if (!sessi
pmarko 2016/12/08 17:02:00 See comment in http_stream_factory_impl_job.cc - I
continue;
if (!IsQuicWhitelistedForHost(origin.host()))
@@ -1037,7 +1037,7 @@ bool HttpStreamFactoryImpl::JobController::
if (alternative_proxy_server->is_quic()) {
// Check that QUIC is enabled globally, and it is not disabled.
- if (!session_->params().enable_quic ||
+ if (!session_->params().is_enable_quic_for_new_streams() ||
Bence 2016/12/02 18:53:26 I believe this should be gated on all three: if (!
pmarko 2016/12/08 17:02:00 See comment in http_stream_factory_impl_job.cc - I
session_->quic_stream_factory()->IsQuicDisabled()) {
return false;
}
« net/http/http_stream_factory_impl_job.cc ('K') | « net/http/http_stream_factory_impl_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698