Respect QuicAllowed policy for new streams

net/http/http_stream_factory_impl_job.cc

Index: net/http/http_stream_factory_impl_job.cc
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index 3190b9141ad97b6d216a1b1295f3edaa475375ab..909f564d91b72202ae01115da4e9477b8d04380f 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -736,7 +736,7 @@ int HttpStreamFactoryImpl::Job::DoResolveProxyComplete(int result) {
         ProxyServer::SCHEME_HTTPS | ProxyServer::SCHEME_SOCKS4 |
         ProxyServer::SCHEME_SOCKS5;
 
-    if (session_->params().enable_quic)
+    if (session_->params().is_enable_quic_for_new_streams())

[Bence, 2016/12/02 18:53:26]

I believe this should be gated on both:
if (session_->params().enable_quic &&
    session_->params().enable_quic_for_new_streams())

[pmarko, 2016/12/08 17:02:00]

The way I've done it in my first attempt is that enable_quic_for_new_streams()
checks for that internally.

So basically, enable_quic_for_new_streams() == (enable_quic && (shared_params ==
null || shared_params->enable_quic_for_new_streams))

Would you prefer to decouple those and have the callers explicitly do
params->enable_quic && params->enable_quic_for_new_streams() ?
Or do you think enable_quic_for_new_streams() should check for the "general
enable_quic" implicitly as it is now?

[Bence, 2016/12/08 17:41:59]

Okay, I see.  I think what you are doing is fine.

[pmarko, 2016/12/08 19:56:54]

OK thanks! I've added that information to the method comment in
http_network_session.h

       supported_proxies |= ProxyServer::SCHEME_QUIC;
 
     proxy_info_.RemoveProxiesWithoutScheme(supported_proxies);