Respect QuicAllowed policy for new streams

net/http/http_stream_factory_impl_job_controller.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory_impl_job_controller.h"
 
 #include <memory>
 #include <string>
 #include <utility>
 
@@ skipping 919 matching lines @@
     }
 
     DCHECK_EQ(kProtoQUIC, alternative_service.protocol);
     if (origin.host() != alternative_service.host &&
         !session_->params()
              .enable_quic_alternative_service_with_different_host) {
       continue;
     }
 
     quic_all_broken = false;
-    if (!session_->params().enable_quic)
+    if (!session_->params().is_enable_quic_for_new_streams())

[Bence, 2016/12/02 18:53:26]

I believe this should be gated on both:
if (!session_->params().enable_quic ||
    !session_->params().enable_quic_for_new_streams())

[pmarko, 2016/12/08 17:02:00]

See comment in http_stream_factory_impl_job.cc - I'll change all three
references if you prefer to decouple enable_quic_for_new_streams() from the
general enable_quic flag. 

       continue;
 
     if (!IsQuicWhitelistedForHost(origin.host()))
       continue;
 
     if (stream_type == HttpStreamRequest::BIDIRECTIONAL_STREAM &&
         session_->params().quic_disable_bidirectional_streams) {
       continue;
     }
 
@@ skipping 79 matching lines @@
   DCHECK(!(*alternative_proxy_server == proxy_info.proxy_server()));
 
   if (!alternative_proxy_server->is_https() &&
       !alternative_proxy_server->is_quic()) {
     // Alternative proxy server should be a secure server.
     return false;
   }
 
   if (alternative_proxy_server->is_quic()) {
     // Check that QUIC is enabled globally, and it is not disabled.
-    if (!session_->params().enable_quic ||
+    if (!session_->params().is_enable_quic_for_new_streams() ||

[Bence, 2016/12/02 18:53:26]

I believe this should be gated on all three:
if (!session_->params().enable_quic ||
    !session_->params().enable_quic_for_new_streams() ||
    session_->quic_stream_factor()->IsQuicDisabled()) {

[pmarko, 2016/12/08 17:02:00]

See comment in http_stream_factory_impl_job.cc - I'll change all three
references if you prefer to decouple enable_quic_for_new_streams() from the
general enable_quic flag. 

         session_->quic_stream_factory()->IsQuicDisabled()) {
       return false;
     }
   }
 
   return true;
 }
 
 void HttpStreamFactoryImpl::JobController::ReportAlternateProtocolUsage(
     Job* job) const {
@@ skipping 20 matching lines @@
 }
 
 void HttpStreamFactoryImpl::JobController::StartAlternativeProxyServerJob() {
   if (!alternative_job_ || !request_)
     return;
   DCHECK(alternative_job_->alternative_proxy_server().is_valid());
   alternative_job_->Start(request_->stream_type());
 }
 
 }  // namespace net