Respect QuicAllowed policy for new streams

net/http/http_stream_factory_impl_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory_impl_job.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 718 matching lines @@
 int HttpStreamFactoryImpl::Job::DoResolveProxyComplete(int result) {
   pac_request_ = NULL;
 
   if (result == OK) {
     // Remove unsupported proxies from the list.
     int supported_proxies =
         ProxyServer::SCHEME_DIRECT | ProxyServer::SCHEME_HTTP |
         ProxyServer::SCHEME_HTTPS | ProxyServer::SCHEME_SOCKS4 |
         ProxyServer::SCHEME_SOCKS5;
 
-    if (session_->params().enable_quic)
+    if (session_->params().is_enable_quic_for_new_streams())

[Bence, 2016/12/02 18:53:26]

I believe this should be gated on both:
if (session_->params().enable_quic &&
    session_->params().enable_quic_for_new_streams())

[pmarko, 2016/12/08 17:02:00]

The way I've done it in my first attempt is that enable_quic_for_new_streams()
checks for that internally.

So basically, enable_quic_for_new_streams() == (enable_quic && (shared_params ==
null || shared_params->enable_quic_for_new_streams))

Would you prefer to decouple those and have the callers explicitly do
params->enable_quic && params->enable_quic_for_new_streams() ?
Or do you think enable_quic_for_new_streams() should check for the "general
enable_quic" implicitly as it is now?

[Bence, 2016/12/08 17:41:59]

Okay, I see.  I think what you are doing is fine.

[pmarko, 2016/12/08 19:56:54]

OK thanks! I've added that information to the method comment in
http_network_session.h

       supported_proxies |= ProxyServer::SCHEME_QUIC;
 
     proxy_info_.RemoveProxiesWithoutScheme(supported_proxies);
 
     if (proxy_info_.is_empty()) {
       // No proxies/direct to choose from. This happens when we don't support
       // any of the proxies in the returned list.
       result = ERR_NO_SUPPORTED_PROXIES;
     } else if (using_quic_ &&
                (!proxy_info_.is_quic() && !proxy_info_.is_direct())) {
@@ skipping 749 matching lines @@
 
   ConnectionAttempts socket_attempts = connection_->connection_attempts();
   if (connection_->socket()) {
     connection_->socket()->GetConnectionAttempts(&socket_attempts);
   }
 
   delegate_->AddConnectionAttemptsToRequest(this, socket_attempts);
 }
 
 }  // namespace net