Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/Source/core/dom/StyleElement.cpp

Issue 2546393002: Make setNeedsActiveStyleUpdate mark treescope dirty only. (Closed)
Patch Set: Rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/StyleElement.cpp
diff --git a/third_party/WebKit/Source/core/dom/StyleElement.cpp b/third_party/WebKit/Source/core/dom/StyleElement.cpp
index 88164e2fe64cae286488f553ce3dbbd125a969f9..b403f52b69c664e658dfd09c45ae2089d7fc2a9e 100644
--- a/third_party/WebKit/Source/core/dom/StyleElement.cpp
+++ b/third_party/WebKit/Source/core/dom/StyleElement.cpp
@@ -82,13 +82,14 @@ void StyleElement::removedFrom(Element& element,
m_registeredAsCandidate = false;
}
- StyleSheet* removedSheet = m_sheet.get();
-
- if (m_sheet)
+ if (m_sheet) {
clearSheet(element);
- if (removedSheet)
- document.styleEngine().setNeedsActiveStyleUpdate(removedSheet,
- AnalyzedStyleUpdate);
+ if (element.isConnected()) {
+ // TODO(rune@opera.com): resolverChanged() can be removed once stylesheet
+ // updates are async. https://crbug.com/567021
+ document.styleEngine().resolverChanged(AnalyzedStyleUpdate);
+ }
+ }
}
StyleElement::ProcessingResult StyleElement::childrenChanged(Element& element) {
« no previous file with comments | « third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp ('k') | third_party/WebKit/Source/core/dom/StyleEngine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698