Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2546353002: Move oof-descendants to NGPhysicalFragmentBase (Closed)

Created:
4 years ago by atotic
Modified:
4 years ago
Reviewers:
ikilpatrick
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move oof-descendants to NGPhysicalFragmentBase As discussed in CR https://codereview.chromium.org/2540653003 As ng_text_fragments can also have oof descendants, oof descendants should move to NGPhysicalFragmentBase BUG=635619 Committed: https://crrev.com/bec09e64258ed346ac17bf741595275c3778087d Cr-Commit-Position: refs/heads/master@{#436477}

Patch Set 1 #

Patch Set 2 : fix win build problem #

Messages

Total messages: 13 (7 generated)
atotic
ptal
4 years ago (2016-12-05 08:06:30 UTC) #2
ikilpatrick
lgtm
4 years ago (2016-12-05 18:43:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546353002/1
4 years ago (2016-12-05 21:00:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546353002/20001
4 years ago (2016-12-05 23:44:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 01:04:52 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-06 01:08:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bec09e64258ed346ac17bf741595275c3778087d
Cr-Commit-Position: refs/heads/master@{#436477}

Powered by Google App Engine
This is Rietveld 408576698