[CSS Typed OM] Add additional test capability for string->CSSStyleValue in property-suite

[CSS Typed OM] Add additional test capability for string->CSSStyleValue in property-suite

Adds the ability for property-suite to test string values that are represented the same as something else in Typed OM.

Converts the remaining inlinestyle/transform-rotate.html tests to use property-suite.

BUG=545318
Committed: https://crrev.com/36f398db3217b9aa29a30cdfe51cd8b6b037426b
Cr-Commit-Position: refs/heads/master@{#439735}

[meade_UTC10, 2016-12-09 04:40:09]

Description was changed from

==========
Add tests, and update property suite for transforms

BUG=
==========

to

==========
[CSS Typed OM] Add additional test capability for string->CSSStyleValue in
property-suite

Adds the ability for property-suite to test string values that are represented
the same as something else in Typed OM

BUG=545318
==========

[meade_UTC10, 2016-12-09 05:08:47]

Description was changed from

==========
[CSS Typed OM] Add additional test capability for string->CSSStyleValue in
property-suite

Adds the ability for property-suite to test string values that are represented
the same as something else in Typed OM

BUG=545318
==========

to

==========
[CSS Typed OM] Add additional test capability for string->CSSStyleValue in
property-suite

Adds the ability for property-suite to test string values that are represented
the same as something else in Typed OM.

Converts the remaining inlinestyle/transform-rotate.html tests to use
property-suite.

BUG=545318
==========

[meade_UTC10, 2016-12-09 05:09:51]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 05:10:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2016-12-09 05:10:18]

meade@chromium.org changed reviewers:
+ rjwright@chromium.org

[commit-bot: I haz the power, 2016-12-09 05:12:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 05:12:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[meade_UTC10, 2016-12-19 01:18:22]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 01:18:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 01:20:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 01:20:04]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[meade_UTC10, 2016-12-19 04:40:38]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 04:40:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2016-12-19 04:45:26]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 04:45:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rjwright, 2016-12-19 05:31:44]

lgtm

https://codereview.chromium.org/2546343002/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js
(right):

https://codereview.chromium.org/2546343002/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js:137:
}, 'Getting ' + propertyName + ' it is set to ' +
Kinda strangely worded description. Did you accidentally a full stop?

[rjwright, 2016-12-19 05:31:48]

lgtm

[commit-bot: I haz the power, 2016-12-19 05:50:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 05:50:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[meade_UTC10, 2016-12-19 06:43:45]

https://codereview.chromium.org/2546343002/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js
(right):

https://codereview.chromium.org/2546343002/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js:137:
}, 'Getting ' + propertyName + ' it is set to ' +
On 2016/12/19 05:31:44, rjwright wrote:
> Kinda strangely worded description. Did you accidentally a full stop?

I think it's missing a "when"..
e.g.
'Getting left when it is set to "calc(10px + 2em)" via a string'

[meade_UTC10, 2016-12-19 06:43:59]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-12-19 06:43:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjwright@chromium.org
Link to the patchset: https://codereview.chromium.org/2546343002/#ps140001
(title: "Update test name strings")

[commit-bot: I haz the power, 2016-12-19 06:44:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 07:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 07:44:17]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[meade_UTC10, 2016-12-20 06:34:09]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-12-20 06:34:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjwright@chromium.org
Link to the patchset: https://codereview.chromium.org/2546343002/#ps160001
(title: "fix location of quotes")

[commit-bot: I haz the power, 2016-12-20 06:34:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 07:46:26]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1482215649114960,
"parent_rev": "a2ef222f00a831de54a2c26ab2c1ffc422c0a49a", "commit_rev":
"c7e9c86283e317325ab1db7151432ca6549801b5"}

[commit-bot: I haz the power, 2016-12-20 07:46:51]

Description was changed from

==========
[CSS Typed OM] Add additional test capability for string->CSSStyleValue in
property-suite

Adds the ability for property-suite to test string values that are represented
the same as something else in Typed OM.

Converts the remaining inlinestyle/transform-rotate.html tests to use
property-suite.

BUG=545318
==========

to

==========
[CSS Typed OM] Add additional test capability for string->CSSStyleValue in
property-suite

Adds the ability for property-suite to test string values that are represented
the same as something else in Typed OM.

Converts the remaining inlinestyle/transform-rotate.html tests to use
property-suite.

BUG=545318

Review-Url: https://codereview.chromium.org/2546343002
==========

[commit-bot: I haz the power, 2016-12-20 07:46:52]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-12-20 07:49:44]

Description was changed from

==========
[CSS Typed OM] Add additional test capability for string->CSSStyleValue in
property-suite

Adds the ability for property-suite to test string values that are represented
the same as something else in Typed OM.

Converts the remaining inlinestyle/transform-rotate.html tests to use
property-suite.

BUG=545318

Review-Url: https://codereview.chromium.org/2546343002
==========

to

==========
[CSS Typed OM] Add additional test capability for string->CSSStyleValue in
property-suite

Adds the ability for property-suite to test string values that are represented
the same as something else in Typed OM.

Converts the remaining inlinestyle/transform-rotate.html tests to use
property-suite.

BUG=545318

Committed: https://crrev.com/36f398db3217b9aa29a30cdfe51cd8b6b037426b
Cr-Commit-Position: refs/heads/master@{#439735}
==========

[commit-bot: I haz the power, 2016-12-20 07:49:45]

Patchset 9 (id:??) landed as
https://crrev.com/36f398db3217b9aa29a30cdfe51cd8b6b037426b
Cr-Commit-Position: refs/heads/master@{#439735}