[CSS Typed OM] Add CSSValue->CSSSkew conversions

Add CSSValue->CSSSkew conversions

This allows getting transforms containing skews from StylePropertyMaps.

Previously:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')  // null

now:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')
// CSSTransformValue([CSSSkew(30deg)])

BUG=545318
Committed: https://crrev.com/64d7465064fce35ba81eebf4db4665dff6aa34df
Cr-Commit-Position: refs/heads/master@{#439959}

[meade_UTC10, 2016-11-22 02:38:59]

meade@chromium.org changed reviewers:
+ rjwright@chromium.org

[rjwright, 2016-11-27 03:57:33]

On 2016/11/22 02:39:00, Eddy wrote:

lgtm

[meade_UTC10, 2016-11-27 23:57:32]

meade@chromium.org changed reviewers:
+ sashab@chromium.org

[meade_UTC10, 2016-11-27 23:57:32]

Thanks Renee! Sasha, PTAL?

[meade_UTC10, 2016-11-28 02:58:13]

Description was changed from

==========
Add CSSValue->CSSSkew conversions

This allows getting transforms containing skews from StylePropertyMaps.

BUG=545318
==========

to

==========
Add CSSValue->CSSSkew conversions

This allows getting transforms containing skews from StylePropertyMaps.

Previously:
element.style.transform = 'skew(30deg');
element.styleMap.get('transform')  // null

now:
element.style.transform = 'skew(30deg');
element.styleMap.get('transform')  
// CSSTransformValue([CSSSkew(30deg)])

BUG=545318
==========

[sashab, 2016-11-28 03:02:27]

sashab@chromium.org changed reviewers:
+ timloh@chromium.org

[sashab, 2016-11-28 03:02:27]

Assigning to Timloh who I think is a better reviewer for this :)

Also CL description isn't great, more context would be better :)

[Timothy Loh, 2016-11-29 03:49:37]

lgtm

Typo in description: 'skew(30deg');

https://codereview.chromium.org/2514043002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp (right):

https://codereview.chromium.org/2514043002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp:15: if
(xValue.isCalculated()) {
Maybe add a TODO to handle this and the below calc cases.

[meade_UTC10, 2016-11-29 05:17:19]

Description was changed from

==========
Add CSSValue->CSSSkew conversions

This allows getting transforms containing skews from StylePropertyMaps.

Previously:
element.style.transform = 'skew(30deg');
element.styleMap.get('transform')  // null

now:
element.style.transform = 'skew(30deg');
element.styleMap.get('transform')  
// CSSTransformValue([CSSSkew(30deg)])

BUG=545318
==========

to

==========
Add CSSValue->CSSSkew conversions

This allows getting transforms containing skews from StylePropertyMaps.

Previously:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')  // null

now:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')  
// CSSTransformValue([CSSSkew(30deg)])

BUG=545318
==========

[meade_UTC10, 2016-11-29 05:18:03]

https://codereview.chromium.org/2514043002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp (right):

https://codereview.chromium.org/2514043002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp:15: if
(xValue.isCalculated()) {
On 2016/11/29 03:49:37, Timothy Loh wrote:
> Maybe add a TODO to handle this and the below calc cases.

Done.

[meade_UTC10, 2016-11-29 05:18:11]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-11-29 05:18:11]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org,
rjwright@chromium.org
Link to the patchset: https://codereview.chromium.org/2514043002/#ps20001
(title: "Add TODO")

[commit-bot: I haz the power, 2016-11-29 05:18:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 05:39:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 05:39:16]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[meade_UTC10, 2016-11-29 06:22:33]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 06:22:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2016-12-09 05:44:41]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 05:44:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 05:47:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 05:47:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[meade_UTC10, 2016-12-09 05:55:56]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 05:56:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 05:59:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 05:59:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[meade_UTC10, 2016-12-09 06:05:45]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 06:06:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 06:09:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 06:09:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[meade_UTC10, 2016-12-09 06:57:18]

I'm not sure what's up with the patch failures, but I rearranged this patch a
little to match with the other patches I have up. Please take another look?

[meade_UTC10, 2016-12-19 01:10:15]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 01:10:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 01:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 01:12:03]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[meade_UTC10, 2016-12-19 04:50:06]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 04:50:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 06:20:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 06:20:32]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[meade_UTC10, 2016-12-19 06:48:02]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 06:48:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2016-12-19 06:50:30]

Renee/Sasha (in place of Tim): given the significant changes that were made to
this CL, could you please take another look?

Thanks!

[commit-bot: I haz the power, 2016-12-19 08:33:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 08:33:49]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sashab, 2016-12-19 23:26:02]

Still LGTM, if renee's happy with it. :)

[meade_UTC10, 2016-12-20 06:35:23]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 06:35:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 09:58:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 09:58:38]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2016-12-21 00:51:41]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-12-21 00:51:41]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org,
rjwright@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2514043002/#ps240001
(title: "Merge branch 'update-transform-tests' into cssskew-fromcssvalue-2")

[commit-bot: I haz the power, 2016-12-21 00:52:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 00:59:01]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1482281501191620,
"parent_rev": "832ab25ee82a9002ce6c1ef37c20147d09857a28", "commit_rev":
"b8622ec1deb4973a6212a25360f8fc6c8761262d"}

[commit-bot: I haz the power, 2016-12-21 00:59:28]

Description was changed from

==========
Add CSSValue->CSSSkew conversions

This allows getting transforms containing skews from StylePropertyMaps.

Previously:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')  // null

now:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')  
// CSSTransformValue([CSSSkew(30deg)])

BUG=545318
==========

to

==========
Add CSSValue->CSSSkew conversions

This allows getting transforms containing skews from StylePropertyMaps.

Previously:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')  // null

now:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')  
// CSSTransformValue([CSSSkew(30deg)])

BUG=545318

Review-Url: https://codereview.chromium.org/2514043002
==========

[commit-bot: I haz the power, 2016-12-21 00:59:30]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-12-21 01:01:18]

Description was changed from

==========
Add CSSValue->CSSSkew conversions

This allows getting transforms containing skews from StylePropertyMaps.

Previously:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')  // null

now:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')  
// CSSTransformValue([CSSSkew(30deg)])

BUG=545318

Review-Url: https://codereview.chromium.org/2514043002
==========

to

==========
Add CSSValue->CSSSkew conversions

This allows getting transforms containing skews from StylePropertyMaps.

Previously:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')  // null

now:
element.style.transform = 'skew(30deg)';
element.styleMap.get('transform')
// CSSTransformValue([CSSSkew(30deg)])

BUG=545318

Committed: https://crrev.com/64d7465064fce35ba81eebf4db4665dff6aa34df
Cr-Commit-Position: refs/heads/master@{#439959}
==========

[commit-bot: I haz the power, 2016-12-21 01:01:19]

Patchset 13 (id:??) landed as
https://crrev.com/64d7465064fce35ba81eebf4db4665dff6aa34df
Cr-Commit-Position: refs/heads/master@{#439959}