Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2546183002: Revert "Android shouldn't fire focus events when the WebView itself isn't focused" (Closed)

Created:
4 years ago by dmazzoni
Modified:
4 years ago
Reviewers:
David Tseng
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge to M56: Revert "Android shouldn't fire focus events when the WebView itself isn't focused" Caused http://crbug.com/667559 - when clicking on a <select> pop-up and then returning to the page, focus was being reset to the whole page rather than back to the select element. Original changelist: https://chromiumcodereview.appspot.com/2416293002 BUG=648391, 667559 TBR=dtseng@chromium.org Review-Url: https://codereview.chromium.org/2547903002 Cr-Commit-Position: refs/heads/master@{#435964} (cherry picked from commit c2607397665f0a0a8e3b16198dbeaae2a9e1e0bb) Committed: https://chromium.googlesource.com/chromium/src/+/7fa77424b02d63b38bb1262471cc4af8e3f54fc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 4 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
dmazzoni
4 years ago (2016-12-02 20:10:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7fa77424b02d63b38bb1262471cc4af8e3f54fc0.

Powered by Google App Engine
This is Rietveld 408576698