Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2547903002: Revert "Android shouldn't fire focus events when the WebView itself isn't focused" (Closed)

Created:
4 years ago by dmazzoni
Modified:
4 years ago
Reviewers:
David Tseng
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Android shouldn't fire focus events when the WebView itself isn't focused" Caused http://crbug.com/667559 - when clicking on a <select> pop-up and then returning to the page, focus was being reset to the whole page rather than back to the select element. Original changelist: https://chromiumcodereview.appspot.com/2416293002 BUG=648391, 667559 TBR=dtseng@chromium.org Committed: https://crrev.com/c2607397665f0a0a8e3b16198dbeaae2a9e1e0bb Cr-Commit-Position: refs/heads/master@{#435964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 4 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547903002/1
4 years ago (2016-12-02 16:52:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 17:30:10 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-02 17:32:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2607397665f0a0a8e3b16198dbeaae2a9e1e0bb
Cr-Commit-Position: refs/heads/master@{#435964}

Powered by Google App Engine
This is Rietveld 408576698