Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 2546183002: Revert "Android shouldn't fire focus events when the WebView itself isn't focused" (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
index d386d6d91a950a2211dfaca269718e5636415f13..994b458a1e68c5f36c208eaa95734097b4f77206 100644
--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
@@ -772,16 +772,13 @@ public class BrowserAccessibilityManager {
@CalledByNative
private void handleFocusChanged(int id) {
if (mNativeObj == 0) return;
- if (mAccessibilityFocusId != View.NO_ID) {
- sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_FOCUSED);
- moveAccessibilityFocusToId(id);
- }
+ sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_FOCUSED);
+ moveAccessibilityFocusToId(id);
}
@CalledByNative
private void handleCheckStateChanged(int id) {
if (mNativeObj == 0) return;
- if (mAccessibilityFocusId == View.NO_ID) return;
sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_CLICKED);
}
@@ -794,21 +791,18 @@ public class BrowserAccessibilityManager {
@CalledByNative
private void handleTextSelectionChanged(int id) {
if (mNativeObj == 0) return;
- if (mAccessibilityFocusId == View.NO_ID) return;
sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_TEXT_SELECTION_CHANGED);
}
@CalledByNative
private void handleEditableTextChanged(int id) {
if (mNativeObj == 0) return;
- if (mAccessibilityFocusId == View.NO_ID) return;
sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_TEXT_CHANGED);
}
@CalledByNative
private void handleSliderChanged(int id) {
if (mNativeObj == 0) return;
- if (mAccessibilityFocusId == View.NO_ID) return;
sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_SCROLLED);
}
@@ -843,9 +837,7 @@ public class BrowserAccessibilityManager {
@CalledByNative
private void handleScrolledToAnchor(int id) {
if (mNativeObj == 0) return;
- if (mAccessibilityFocusId != View.NO_ID) {
- moveAccessibilityFocusToId(id);
- }
+ moveAccessibilityFocusToId(id);
}
@CalledByNative
@@ -864,7 +856,6 @@ public class BrowserAccessibilityManager {
@CalledByNative
private void announceLiveRegionText(String text) {
- if (mAccessibilityFocusId == View.NO_ID) return;
mView.announceForAccessibility(text);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698