Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2545923005: Create Tether Chrome OS component and add a skeleton Initializer class. (Closed)

Created:
4 years ago by Kyle Horimoto
Modified:
4 years ago
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create Tether Chrome OS component and add a skeleton Initializer class. Committed: https://crrev.com/4c53995f0b8ea16729f63fc5e9c012335b3df302 Cr-Commit-Position: refs/heads/master@{#436184}

Patch Set 1 #

Patch Set 2 : Add comment. #

Patch Set 3 : Make chromeos_components_unittests a top-level test. #

Total comments: 2

Patch Set 4 : Address stevenjb@ comment. #

Patch Set 5 : Rebased. #

Patch Set 6 : Added test dependency on //base/test:test_support. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -0 lines) Patch
M BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A chromeos/components/BUILD.gn View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download
A chromeos/components/run_all_unittests.cc View 1 chunk +14 lines, -0 lines 0 comments Download
A chromeos/components/tether/BUILD.gn View 1 chunk +44 lines, -0 lines 0 comments Download
A chromeos/components/tether/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A chromeos/components/tether/initializer.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A chromeos/components/tether/initializer.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
Kyle Horimoto
4 years ago (2016-12-01 23:55:45 UTC) #2
stevenjb
https://codereview.chromium.org/2545923005/diff/40001/chromeos/components/BUILD.gn File chromeos/components/BUILD.gn (right): https://codereview.chromium.org/2545923005/diff/40001/chromeos/components/BUILD.gn#newcode13 chromeos/components/BUILD.gn:13: } Rather than package all of the components as ...
4 years ago (2016-12-02 00:04:19 UTC) #3
Kyle Horimoto
https://codereview.chromium.org/2545923005/diff/40001/chromeos/components/BUILD.gn File chromeos/components/BUILD.gn (right): https://codereview.chromium.org/2545923005/diff/40001/chromeos/components/BUILD.gn#newcode13 chromeos/components/BUILD.gn:13: } On 2016/12/02 00:04:19, stevenjb wrote: > Rather than ...
4 years ago (2016-12-02 00:17:47 UTC) #5
Ben Goodger (Google)
lgtm
4 years ago (2016-12-03 02:44:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545923005/60001
4 years ago (2016-12-04 00:32:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/317125) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-04 00:34:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545923005/80001
4 years ago (2016-12-04 00:40:01 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/245620)
4 years ago (2016-12-04 00:43:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545923005/100001
4 years ago (2016-12-04 01:38:08 UTC) #18
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years ago (2016-12-04 02:37:39 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-04 02:39:44 UTC) #22
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/4c53995f0b8ea16729f63fc5e9c012335b3df302
Cr-Commit-Position: refs/heads/master@{#436184}

Powered by Google App Engine
This is Rietveld 408576698