Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 2545653002: (Reland) Insert logcat as part of test result for android instrumentation tests. (Closed)

Created:
3 years, 8 months ago by BigBossZhiling
Modified:
3 years, 8 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Reland) Insert logcat as part of test result for android instrumentation tests. In this cl, we are trying to add the logcat of each instrumentation test into the corresponding test result object, so that when we are checking the result of each test case, we would be able to see the corresponding logcat for that test case at the same time. The reason of reland is to fix the issue where environmental variables are not set. BUG=631213 Committed: https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9 Cr-Commit-Position: refs/heads/master@{#435550}

Patch Set 1 #

Patch Set 2 : add logging for exception #

Total comments: 4

Patch Set 3 : add more exceptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -3 lines) Patch
A build/android/pylib/android/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
A build/android/pylib/android/logdog_logcat_monitor.py View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
M build/android/pylib/base/base_test_result.py View 2 chunks +7 lines, -0 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 3 chunks +10 lines, -0 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 3 chunks +14 lines, -3 lines 0 comments Download
M build/android/pylib/results/json_results.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/test_runner.pydeps View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
BigBossZhiling
3 years, 8 months ago (2016-12-01 01:35:14 UTC) #3
BigBossZhiling
added exception catch for bootstrap errors.
3 years, 8 months ago (2016-12-01 01:35:38 UTC) #4
jbudorick
https://codereview.chromium.org/2545653002/diff/20001/build/android/pylib/android/logdog_logcat_monitor.py File build/android/pylib/android/logdog_logcat_monitor.py (right): https://codereview.chromium.org/2545653002/diff/20001/build/android/pylib/android/logdog_logcat_monitor.py#newcode33 build/android/pylib/android/logdog_logcat_monitor.py:33: except ValueError as e: given the number of KeyErrors ...
3 years, 8 months ago (2016-12-01 01:56:18 UTC) #5
BigBossZhiling
https://codereview.chromium.org/2545653002/diff/20001/build/android/pylib/android/logdog_logcat_monitor.py File build/android/pylib/android/logdog_logcat_monitor.py (right): https://codereview.chromium.org/2545653002/diff/20001/build/android/pylib/android/logdog_logcat_monitor.py#newcode33 build/android/pylib/android/logdog_logcat_monitor.py:33: except ValueError as e: On 2016/12/01 01:56:18, jbudorick wrote: ...
3 years, 8 months ago (2016-12-01 02:07:41 UTC) #6
jbudorick
lgtm
3 years, 8 months ago (2016-12-01 02:13:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545653002/40001
3 years, 8 months ago (2016-12-01 02:18:25 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 8 months ago (2016-12-01 04:15:53 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9 Cr-Commit-Position: refs/heads/master@{#435550}
3 years, 8 months ago (2016-12-01 04:20:20 UTC) #14
jbudorick
3 years, 8 months ago (2016-12-01 14:47:48 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2548503002/ by jbudorick@chromium.org.

The reason for reverting is: Failing on large suites:
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Te....

Powered by Google App Engine
This is Rietveld 408576698