Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5415)

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 2545653002: (Reland) Insert logcat as part of test result for android instrumentation tests. (Closed)
Patch Set: add more exceptions Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/instrumentation/instrumentation_test_instance.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py
index f8d37e76c0223bc5b3f001268120ccd5cbca42e7..afa04562b0cd694a37e49fc93924c3e83e80ea89 100644
--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py
@@ -442,6 +442,9 @@ class InstrumentationTestInstance(test_instance.TestInstance):
self._store_tombstones = False
self._initializeTombstonesAttributes(args)
+ self._should_save_logcat = None
+ self._initializeLogAttributes(args)
+
def _initializeApkAttributes(self, args, error_func):
if args.apk_under_test:
apk_under_test_path = args.apk_under_test
@@ -594,6 +597,9 @@ class InstrumentationTestInstance(test_instance.TestInstance):
def _initializeTombstonesAttributes(self, args):
self._store_tombstones = args.store_tombstones
+ def _initializeLogAttributes(self, args):
+ self._should_save_logcat = bool(args.json_results_file)
+
@property
def additional_apks(self):
return self._additional_apks
@@ -627,6 +633,10 @@ class InstrumentationTestInstance(test_instance.TestInstance):
return self._flags
@property
+ def should_save_logcat(self):
+ return self._should_save_logcat
+
+ @property
def package_info(self):
return self._package_info

Powered by Google App Engine
This is Rietveld 408576698