Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2548503002: Revert of (Reland) Insert logcat as part of test result for android instrumentation tests. (Closed)

Created:
4 years ago by jbudorick
Modified:
4 years ago
Reviewers:
BigBossZhiling
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of (Reland) Insert logcat as part of test result for android instrumentation tests. (patchset #3 id:40001 of https://codereview.chromium.org/2545653002/ ) Reason for revert: Failing on large suites: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/5996/steps/chrome_public_test_apk/logs/stdio Original issue's description: > (Reland) Insert logcat as part of test result for android instrumentation tests. > > In this cl, we are trying to add the logcat of each instrumentation > test into the corresponding test result object, so that when we are > checking the result of each test case, we would be able to see the > corresponding logcat for that test case at the same time. > > The reason of reland is to fix the issue where environmental variables are not set. > > BUG=631213 > > Committed: https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9 > Cr-Commit-Position: refs/heads/master@{#435550} TBR=hzl@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631213 Committed: https://crrev.com/8ada01f1acd69c5d93f92a725c86033a33b6de58 Cr-Commit-Position: refs/heads/master@{#435606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -133 lines) Patch
D build/android/pylib/android/__init__.py View 1 chunk +0 lines, -4 lines 0 comments Download
D build/android/pylib/android/logdog_logcat_monitor.py View 1 chunk +0 lines, -89 lines 0 comments Download
M build/android/pylib/base/base_test_result.py View 2 chunks +0 lines, -7 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 3 chunks +0 lines, -10 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 3 chunks +3 lines, -14 lines 0 comments Download
M build/android/pylib/results/json_results.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/test_runner.pydeps View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jbudorick
Created Revert of (Reland) Insert logcat as part of test result for android instrumentation tests.
4 years ago (2016-12-01 14:47:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548503002/1
4 years ago (2016-12-01 14:49:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 15:03:02 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-01 15:05:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ada01f1acd69c5d93f92a725c86033a33b6de58
Cr-Commit-Position: refs/heads/master@{#435606}

Powered by Google App Engine
This is Rietveld 408576698