Handle synthetic nodes use to throw exceptions

Handle synthetic nodes use to throw exceptions

- Implement:
- - _genericNoSuchMethod
- - _unresolvedConstructorError
- - _malformedTypeError

- Temporarily change NoSuchMethod.toString to avoid a closure.
- Temporarily provide argument to StringBuffer to work around bug.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/3e7aaeebe4e39cdb9dd7192df46560e01cfd271f

[sra1, 2016-12-02 22:09:52]

Description was changed from

==========
Handle synthetic nodes use to throw exceptions

- Temporarily change NoSuchMethod.toString to avoid a closure.

BUG=
==========

to

==========
Handle synthetic nodes use to throw exceptions

- Implement:
- - _genericNoSuchMethod
- - _unresolvedConstructorError
- - _malformedTypeError

- Temporarily change NoSuchMethod.toString to avoid a closure.
- Temporarily provide argument to StringBuffer to work around bug.

BUG=
==========

[sra1, 2016-12-02 22:09:52]

sra@google.com changed reviewers:
+ efortuna@google.com, sigmund@google.com

[Siggi Cherem (dart-lang), 2016-12-02 23:44:18]

lgtm

Up to you on submitting the changes to the libs. I'm inlcined to exclude the one
in core_patch. Either way, I'd also mark the changes we want to revert with a
TODO.

https://codereview.chromium.org/2545153002/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend_impact.dart (right):

https://codereview.chromium.org/2545153002/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend_impact.dart:165:
helpers.genericNoSuchMethod, // Used by kernel.
should we make this conditional?

if (compiler.options.useKernel) ...add(x,y)

[sra1, 2016-12-03 00:11:37]

Description was changed from

==========
Handle synthetic nodes use to throw exceptions

- Implement:
- - _genericNoSuchMethod
- - _unresolvedConstructorError
- - _malformedTypeError

- Temporarily change NoSuchMethod.toString to avoid a closure.
- Temporarily provide argument to StringBuffer to work around bug.

BUG=
==========

to

==========
Handle synthetic nodes use to throw exceptions

- Implement:
- - _genericNoSuchMethod
- - _unresolvedConstructorError
- - _malformedTypeError

- Temporarily change NoSuchMethod.toString to avoid a closure.
- Temporarily provide argument to StringBuffer to work around bug.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3e7aaeebe4e39cdb9dd7192df46560e01cfd271f
==========

[sra1, 2016-12-03 00:11:38]

Committed patchset #3 (id:40001) manually as
3e7aaeebe4e39cdb9dd7192df46560e01cfd271f (presubmit successful).

[sra1, 2016-12-03 00:12:38]

https://codereview.chromium.org/2545153002/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend_impact.dart (right):

https://codereview.chromium.org/2545153002/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend_impact.dart:165:
helpers.genericNoSuchMethod, // Used by kernel.
On 2016/12/02 23:44:18, Siggi Cherem (dart-lang) wrote:
> should we make this conditional?
> 
> if (compiler.options.useKernel) ...add(x,y)

Done.