Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: pkg/compiler/lib/src/js_backend/backend_impact.dart

Issue 2545153002: Handle synthetic nodes use to throw exceptions (Closed)
Patch Set: Also handle malformed type Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend_impact.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend_impact.dart b/pkg/compiler/lib/src/js_backend/backend_impact.dart
index b5b9e72fdef52ab41af1321a920a65dfe07bc438..0ee718f8494faa29e0ef4bec0600f270f602bcee 100644
--- a/pkg/compiler/lib/src/js_backend/backend_impact.dart
+++ b/pkg/compiler/lib/src/js_backend/backend_impact.dart
@@ -161,7 +161,9 @@ class BackendImpacts {
BackendImpact get throwNoSuchMethod {
return _throwNoSuchMethod ??= new BackendImpact(staticUses: [
- helpers.throwNoSuchMethod
+ helpers.throwNoSuchMethod,
+ helpers.genericNoSuchMethod, // Used by kernel.
Siggi Cherem (dart-lang) 2016/12/02 23:44:18 should we make this conditional? if (compiler.opt
sra1 2016/12/03 00:12:38 Done.
+ helpers.unresolvedConstructorError, // Used by kernel.
], otherImpacts: [
// Also register the types of the arguments passed to this method.
_needsList('Needed to encode the arguments for throw NoSuchMethodError.'),
@@ -427,8 +429,10 @@ class BackendImpacts {
BackendImpact _malformedTypeCheck;
BackendImpact get malformedTypeCheck {
- return _malformedTypeCheck ??=
- new BackendImpact(staticUses: [helpers.throwTypeError]);
+ return _malformedTypeCheck ??= new BackendImpact(staticUses: [
+ helpers.throwTypeError,
+ helpers.malformedTypeError, // Used by kernel.
+ ]);
}
BackendImpact _genericTypeCheck;
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend_helpers.dart ('k') | pkg/compiler/lib/src/js_backend/no_such_method_registry.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698