Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2545153002: Handle synthetic nodes use to throw exceptions (Closed)
Patch Set: Also handle malformed type Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder_kernel.dart
diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart
index ce1a9da189aea13dddd1efeafa379e64e883c6d8..8cb831e955493c69ee0adf8be504df009c687edb 100644
--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart
+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart
@@ -796,7 +796,7 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {
HInstruction setListRuntimeTypeInfoIfNeeded(
HInstruction object, ir.ListLiteral listLiteral) {
InterfaceType type = localsHandler
- .substInContext(elements.getType(astAdapter.getNode(listLiteral)));
+ .substInContext(astAdapter.getDartTypeOfListLiteral(listLiteral));
if (!backend.classNeedsRti(type.element) || type.treatAsRaw) {
return object;
}
@@ -827,7 +827,7 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {
setListRuntimeTypeInfoIfNeeded(listInstruction, listLiteral);
}
- TypeMask type = astAdapter.typeOfNewList(targetElement, listLiteral);
+ TypeMask type = astAdapter.typeOfListLiteral(targetElement, listLiteral);
if (!type.containsAll(compiler.closedWorld)) {
listInstruction.instructionType = type;
}
@@ -866,7 +866,7 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {
assert(constructor.kind == ir.ProcedureKind.Factory);
InterfaceType type = localsHandler
- .substInContext(elements.getType(astAdapter.getNode(mapLiteral)));
+ .substInContext(astAdapter.getDartTypeOfMapLiteral(mapLiteral));
ir.Class cls = constructor.enclosingClass;

Powered by Google App Engine
This is Rietveld 408576698