Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2544883006: Cleanup: Replace NTPLoggingTileSource by ntp_tiles::NTPTileSource (Closed)

Created:
4 years ago by Marc Treib
Modified:
4 years ago
Reviewers:
sfiera, nasko, sky
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, ntp-dev+reviews_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, Jered, pedrosimonetti+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Replace NTPLoggingTileSource by ntp_tiles::NTPTileSource BUG=514752 Committed: https://crrev.com/3168fe00c819180c7f56ad697bbc926bc8870e60 Cr-Commit-Position: refs/heads/master@{#436309}

Patch Set 1 #

Patch Set 2 : build deps #

Patch Set 3 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -104 lines) Patch
M chrome/browser/ui/search/search_ipc_router.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 1 2 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_user_data_logger.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc View 4 chunks +8 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc View 1 2 9 chunks +28 lines, -27 lines 0 comments Download
M chrome/common/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/render_messages.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/search/ntp_logging_events.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/renderer/searchbox/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M components/ntp_tiles/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M components/ntp_tiles/ntp_tile.h View 1 chunk +1 line, -14 lines 0 comments Download
A components/ntp_tiles/ntp_tile_source.h View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Marc Treib
This turned out rather bigger than expected... PTAL!
4 years ago (2016-12-02 14:09:33 UTC) #2
sfiera
LGTM
4 years ago (2016-12-02 14:27:10 UTC) #3
Marc Treib
+nasko for render_messages.h, PTAL!
4 years ago (2016-12-02 14:29:43 UTC) #5
nasko
chrome/common/render_messages.h LGTM
4 years ago (2016-12-02 21:43:22 UTC) #6
Marc Treib
+sky for owners approval on chrome/common/DEPS. PTAL, thanks!
4 years ago (2016-12-05 12:56:00 UTC) #16
sky
chrome/common/DEPS LGTM
4 years ago (2016-12-05 16:14:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544883006/40001
4 years ago (2016-12-05 16:15:52 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-05 16:20:58 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-05 16:22:44 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3168fe00c819180c7f56ad697bbc926bc8870e60
Cr-Commit-Position: refs/heads/master@{#436309}

Powered by Google App Engine
This is Rietveld 408576698