Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: chrome/browser/ui/search/search_ipc_router.h

Issue 2544883006: Cleanup: Replace NTPLoggingTileSource by ntp_tiles::NTPTileSource (Closed)
Patch Set: tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/search/search_ipc_router.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SEARCH_SEARCH_IPC_ROUTER_H_ 5 #ifndef CHROME_BROWSER_UI_SEARCH_SEARCH_IPC_ROUTER_H_
6 #define CHROME_BROWSER_UI_SEARCH_SEARCH_IPC_ROUTER_H_ 6 #define CHROME_BROWSER_UI_SEARCH_SEARCH_IPC_ROUTER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/gtest_prod_util.h" 11 #include "base/gtest_prod_util.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/time/time.h" 13 #include "base/time/time.h"
14 #include "chrome/common/search/instant_types.h" 14 #include "chrome/common/search/instant_types.h"
15 #include "chrome/common/search/ntp_logging_events.h" 15 #include "chrome/common/search/ntp_logging_events.h"
16 #include "components/ntp_tiles/ntp_tile_source.h"
16 #include "components/omnibox/common/omnibox_focus_state.h" 17 #include "components/omnibox/common/omnibox_focus_state.h"
17 #include "content/public/browser/web_contents_observer.h" 18 #include "content/public/browser/web_contents_observer.h"
18 #include "ui/base/window_open_disposition.h" 19 #include "ui/base/window_open_disposition.h"
19 20
20 class GURL; 21 class GURL;
21 22
22 namespace content { 23 namespace content {
23 class WebContents; 24 class WebContents;
24 } 25 }
25 26
(...skipping 25 matching lines...) Expand all
51 virtual void OnUndoAllMostVisitedDeletions() = 0; 52 virtual void OnUndoAllMostVisitedDeletions() = 0;
52 53
53 // Called to signal that an event has occurred on the New Tab Page at a 54 // Called to signal that an event has occurred on the New Tab Page at a
54 // particular time since navigation start. 55 // particular time since navigation start.
55 virtual void OnLogEvent(NTPLoggingEventType event, 56 virtual void OnLogEvent(NTPLoggingEventType event,
56 base::TimeDelta time) = 0; 57 base::TimeDelta time) = 0;
57 58
58 // Called to log an impression from a given provider on the New Tab Page. 59 // Called to log an impression from a given provider on the New Tab Page.
59 virtual void OnLogMostVisitedImpression( 60 virtual void OnLogMostVisitedImpression(
60 int position, 61 int position,
61 NTPLoggingTileSource tile_source) = 0; 62 ntp_tiles::NTPTileSource tile_source) = 0;
62 63
63 // Called to log a navigation from a given provider on the New Tab Page. 64 // Called to log a navigation from a given provider on the New Tab Page.
64 virtual void OnLogMostVisitedNavigation( 65 virtual void OnLogMostVisitedNavigation(
65 int position, 66 int position,
66 NTPLoggingTileSource tile_source) = 0; 67 ntp_tiles::NTPTileSource tile_source) = 0;
67 68
68 // Called when the page wants to paste the |text| (or the clipboard contents 69 // Called when the page wants to paste the |text| (or the clipboard contents
69 // if the |text| is empty) into the omnibox. 70 // if the |text| is empty) into the omnibox.
70 virtual void PasteIntoOmnibox(const base::string16& text) = 0; 71 virtual void PasteIntoOmnibox(const base::string16& text) = 0;
71 72
72 // Called when the SearchBox wants to verify the signed-in Chrome identity 73 // Called when the SearchBox wants to verify the signed-in Chrome identity
73 // against the provided |identity|. Will make a round-trip to the browser 74 // against the provided |identity|. Will make a round-trip to the browser
74 // and eventually return the result through SendChromeIdentityCheckResult. 75 // and eventually return the result through SendChromeIdentityCheckResult.
75 // Calls SendChromeIdentityCheckResult with true if the identity matches. 76 // Calls SendChromeIdentityCheckResult with true if the identity matches.
76 virtual void OnChromeIdentityCheck(const base::string16& identity) = 0; 77 virtual void OnChromeIdentityCheck(const base::string16& identity) = 0;
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 void OnInstantSupportDetermined(int page_seq_no, bool supports_instant) const; 174 void OnInstantSupportDetermined(int page_seq_no, bool supports_instant) const;
174 void OnFocusOmnibox(int page_id, OmniboxFocusState state) const; 175 void OnFocusOmnibox(int page_id, OmniboxFocusState state) const;
175 void OnDeleteMostVisitedItem(int page_seq_no, const GURL& url) const; 176 void OnDeleteMostVisitedItem(int page_seq_no, const GURL& url) const;
176 void OnUndoMostVisitedDeletion(int page_seq_no, const GURL& url) const; 177 void OnUndoMostVisitedDeletion(int page_seq_no, const GURL& url) const;
177 void OnUndoAllMostVisitedDeletions(int page_seq_no) const; 178 void OnUndoAllMostVisitedDeletions(int page_seq_no) const;
178 void OnLogEvent(int page_seq_no, 179 void OnLogEvent(int page_seq_no,
179 NTPLoggingEventType event, 180 NTPLoggingEventType event,
180 base::TimeDelta time) const; 181 base::TimeDelta time) const;
181 void OnLogMostVisitedImpression(int page_seq_no, 182 void OnLogMostVisitedImpression(int page_seq_no,
182 int position, 183 int position,
183 NTPLoggingTileSource tile_source) const; 184 ntp_tiles::NTPTileSource tile_source) const;
184 void OnLogMostVisitedNavigation(int page_seq_no, 185 void OnLogMostVisitedNavigation(int page_seq_no,
185 int position, 186 int position,
186 NTPLoggingTileSource tile_source) const; 187 ntp_tiles::NTPTileSource tile_source) const;
187 void OnPasteAndOpenDropDown(int page_seq_no, 188 void OnPasteAndOpenDropDown(int page_seq_no,
188 const base::string16& text) const; 189 const base::string16& text) const;
189 void OnChromeIdentityCheck(int page_seq_no, 190 void OnChromeIdentityCheck(int page_seq_no,
190 const base::string16& identity) const; 191 const base::string16& identity) const;
191 void OnHistorySyncCheck(int page_seq_no) const; 192 void OnHistorySyncCheck(int page_seq_no) const;
192 193
193 // Used by unit tests to set a fake delegate. 194 // Used by unit tests to set a fake delegate.
194 void set_delegate_for_testing(Delegate* delegate); 195 void set_delegate_for_testing(Delegate* delegate);
195 196
196 // Used by unit tests. 197 // Used by unit tests.
(...skipping 12 matching lines...) Expand all
209 // SearchIPCRouter to ensure that delayed IPC replies are ignored. 210 // SearchIPCRouter to ensure that delayed IPC replies are ignored.
210 int commit_counter_; 211 int commit_counter_;
211 212
212 // Set to true, when the tab corresponding to |this| instance is active. 213 // Set to true, when the tab corresponding to |this| instance is active.
213 bool is_active_tab_; 214 bool is_active_tab_;
214 215
215 DISALLOW_COPY_AND_ASSIGN(SearchIPCRouter); 216 DISALLOW_COPY_AND_ASSIGN(SearchIPCRouter);
216 }; 217 };
217 218
218 #endif // CHROME_BROWSER_UI_SEARCH_SEARCH_IPC_ROUTER_H_ 219 #endif // CHROME_BROWSER_UI_SEARCH_SEARCH_IPC_ROUTER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/search/search_ipc_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698